Code Monkey home page Code Monkey logo

Comments (4)

tripodsan avatar tripodsan commented on July 19, 2024

Similar to the sheet-names, that same should be applied to table names.

from helix-data-embed.

davidnuescheler avatar davidnuescheler commented on July 19, 2024

i don't know that addressing sheets really is the correct approach, especially if we consider that there should be information in the excel or google sheet document that should not be exposed. however, instead of (or in addition to) the default behavior of serving the first sheet we should serve a sheet with a specific name, for example helix-default or similar.

using the first sheet is largely problematic for a couple of reasons:

(1) in real life there are usually a number of sheets in a "workbook" (to use excel terminology) and some of them will be manipulated by humans. in those cases the sheet that is output to helix is normally not the one for humans to make changes to. so from a sort order perspective the sheet that helix pulls should definitely not be the first (and possibly should even be hidden in some cases) as it really obstructs the human editor to get to the sheet that they can and should make changes to.

(2) there have been a number of incidents where someone moved a sheet by changing the sheet sort order resulting in a completely different json payload. this can yield catastrophic results depending on how material access to a specific json with a specific structure is for a particular website.

from helix-data-embed.

tripodsan avatar tripodsan commented on July 19, 2024

exactly what I wrote in the description above :-)

from helix-data-embed.

trieloff avatar trieloff commented on July 19, 2024

🎉 This issue has been resolved in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

from helix-data-embed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.