Code Monkey home page Code Monkey logo

Comments (14)

mike-potter avatar mike-potter commented on August 26, 2024 1

I'm not sure I can validate the rest given that error. All I'm able to do is update the version of csstools and then run our script that imports it. If it can't import then the script can't continue. Let me know when you have beta.2 and I can test again.

from css-tools.

jogibear9988 avatar jogibear9988 commented on August 26, 2024

think it's cause of missing .js extensions as i I mentioned in #106

from css-tools.

jogibear9988 avatar jogibear9988 commented on August 26, 2024

I added add_esm_import_extensions.mjs to the build, but it seems for the last build they did not run it.

from css-tools.

jogibear9988 avatar jogibear9988 commented on August 26, 2024

@holblin maybe you should add a npm upload action to github? so you don't manually publish packages

from css-tools.

holblin avatar holblin commented on August 26, 2024

@jogibear9988 it's already running as a GitHub action. As you can see here: https://github.com/adobe/css-tools/actions/runs/4238076267/jobs/7364748837#step:6:68

Though, there was an error on the last execution.

I will check @mike-potter to fix the import for all the use cases (web and node projects).

from css-tools.

holblin avatar holblin commented on August 26, 2024

Hi @mike-potter πŸ‘‹
Could you build it locally #108 and test it?
This should solve this issue but I would like to confirm with you before merging the PR and releasing a new version.
Thanks πŸ‘

from css-tools.

mike-potter avatar mike-potter commented on August 26, 2024

I don't really have a way to build it locally here, but if there is something I can put in my package.json to pin to a specific version or something I can do that.

from css-tools.

holblin avatar holblin commented on August 26, 2024

Could you try version 4.3.0-beta.1?

from css-tools.

mike-potter avatar mike-potter commented on August 26, 2024

Using 4.3.0-beta.1 I get:

import cssTools from '@adobe/css-tools';
       ^^^^^^^^
SyntaxError: The requested module '@adobe/css-tools' does not provide an export named 'default'

from css-tools.

holblin avatar holblin commented on August 26, 2024

Hi @mike-potter could you try:
import * as cssTools from '@adobe/css-tools';

I will add a default export into a beta.2 or rc.1 but that would be great if we could validate the rest πŸ‘

from css-tools.

holblin avatar holblin commented on August 26, 2024

Could you test with 4.3.0-beta.2?

from css-tools.

mike-potter avatar mike-potter commented on August 26, 2024

Yes, beta.2 works! Thanks.

from css-tools.

holblin avatar holblin commented on August 26, 2024

How is the 4.3.0-rc.1 @mike-potter ? Does that also work?
If so I'll release the 4.3.0.

from css-tools.

holblin avatar holblin commented on August 26, 2024

Closed due to no-response + beta.2 was working so I expect the 4.3.0 to work too.

from css-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.