Comments (9)
@zrgt Thank you for raising the issue and the issue is been solved you can find the Bugfixed SMT at below link
[https://github.com/admin-shell-io/submodel-templates
from submodel-templates.
@zrgt Please use the latest JSON file of the respective SMT which as been uploaded yesterday
from submodel-templates.
@Rudra-sandeep the JSON has still problems:
- Properties with different
valueType
s have avalue
='' which is not None, it is string. In cases wherevalueType
is not string it causes errors.
Now:
{
"category": "VARIABLE",
"idShort": "RecordCount",
"semanticId": {
"type": "ExternalReference",
"keys": [
{
"type": "GlobalReference",
"value": "https://admin-shell.io/idta/TimeSeries/Segment/RecordCount/1/1"
}
]
},
"qualifiers": [
{
"type": "Cardinality",
"valueType": "xs:string",
"value": "ZeroToOne"
}
],
"valueType": "xs:long",
"value": "",
"modelType": "Property"
}
Should be:
{
"category": "VARIABLE",
"idShort": "RecordCount",
"semanticId": {
"type": "ExternalReference",
"keys": [
{
"type": "GlobalReference",
"value": "https://admin-shell.io/idta/TimeSeries/Segment/RecordCount/1/1"
}
]
},
"qualifiers": [
{
"type": "Cardinality",
"valueType": "xs:string",
"value": "ZeroToOne"
}
],
"valueType": "xs:long",
"modelType": "Property"
}
- Also in cases where
valueType
is string and value is not set thevalue
key should be just removed from property object. - File object also has an empty string as a value:
"value": ""
. This also should be removed.
Tested with https://github.com/rwth-iat/basyx-python-sdk
from submodel-templates.
The problem also occures in Range
object, as it has min
and max
values which should be removed or set to valid XSD datetime string
{
"idShort": "Timespan",
"description": [
{
"language": "en",
"text": "The valueType of the given timespan must match the valueType of the time properties of the segments."
}
],
"semanticId": {
"type": "ExternalReference",
"keys": [
{
"type": "GlobalReference",
"value": "https://admin-shell.io/idta/TimeSeries/Timespan/1/1"
}
]
},
"valueType": "xs:dateTime",
"min": "",
"max": "",
"modelType": "Range"
}
The same proble appears in DataSpecificationIec61360
with value
:
{
"preferredName": [
{
"language": "de",
"text": "Zeitreihen Metadaten"
},
{
"language": "en",
"text": "time series metadata"
}
],
"shortName": [
{
"language": "de",
"text": "Metadaten"
},
{
"language": "en",
"text": "metadata"
}
],
"definition": [
{
"language": "de",
"text": "Eine Reihe von Daten, welche die Zeitreihe beschreiben und \u00FCber sie Auskunft geben"
},
{
"language": "en",
"text": "A set of data describing and providing information about the time series"
}
],
"value": "",
"modelType": "DataSpecificationIec61360"
}
from submodel-templates.
Also a problem in ExternalReference
in semantiid
of segments. According to Constraint AASd-122 the type of the first key of an ExternalReference must be a GenericGloballyIdentifiable, but "Property" was set:
{
"value": {
"idShort": "Segments",
"semanticId": {
"type": "ExternalReference",
"keys": [
{
"type": "Property",
"value": "https://admin-shell.io/idta/TimeSeries/AggregationMethod/1/1"
}
]
},
"modelType": "SubmodelElementCollection"
}
}
from submodel-templates.
@zrgt Thank you for your feedback I will look into this issues.
from submodel-templates.
@Rudra-sandeep the same problems mentioned in the original issue report also appear in JSON.
from submodel-templates.
@zrgt Thank you for your feedback, I will look into this issue.
@Rudra-sandeep Please consider that probably all issues mentioned in this problem also exist in all JSON files that have been uploaded recently and the Serializer/SDK you are using is not compliant with the AAS Spec.
from submodel-templates.
@zrgt Thank you for your feedback, I will look into this issue.
@Rudra-sandeep Please consider that probably all issues mentioned in this problem also exist in all JSON files that have been uploaded recently and the Serializer/SDK you are using is not compliant with the AAS Spec.
@zrgt Yes regarding to compliant with the Spec we have already started discussions in the WG's
from submodel-templates.
Related Issues (20)
- Direct references to external AAS or Submodels using ReferenceElements or RelationshipElements. HOT 1
- CD's with filled 'category' which is depricated and not supported by API (SMT Service Request Notification) HOT 2
- CD's not acessable in AASPE (error when selecting CD) - SMT Time Series Data
- Wrong DataSpecification ID in various SMT HOT 2
- All Submodel-Templates have wrong Relationship Type in *.rels HOT 2
- SMT `Asset Interfaces Description`: wrong `typeValueListElement` in `SubmodelElementList` HOT 6
- AAS Submodel Time-series Data Usage in combination with ontology modeling HOT 3
- Documentation of SML with SMC as child in Submodel Template (SMT) specifications HOT 4
- Template_HierarchicalStructuresEnablingBoM not opening in AASX Package Explorer HOT 3
- Basic example for HierarchicalStructures submodel
- SMT CarbonFootptint (IDTA 2023-0-9) could not be loaded into AASPE HOT 1
- Example for HandoverDocumentation inconsistent with the spec PDF HOT 1
- Semantic id of DigitalNameplate submodel template has emantic id kind "ConceptDescription" but not "Submodel" HOT 1
- Semantic ID of DocumentClassifiaction in the spec does not match template aasx file HOT 1
- Handover Documentation: Example value of ClassificationSystem does not match spec HOT 1
- renaming of folders
- SMT Technical Data - idShort for MainSection
- Compliance of SMTs with AAS specification HOT 2
- [Feature] Add Github workflow to automatically check/validate model on commit/push
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from submodel-templates.