Code Monkey home page Code Monkey logo

Comments (9)

Rudra-sandeep avatar Rudra-sandeep commented on September 3, 2024 1

@zrgt Thank you for raising the issue and the issue is been solved you can find the Bugfixed SMT at below link
[https://github.com/admin-shell-io/submodel-templates

from submodel-templates.

Rudra-sandeep avatar Rudra-sandeep commented on September 3, 2024

@zrgt Please use the latest JSON file of the respective SMT which as been uploaded yesterday

from submodel-templates.

zrgt avatar zrgt commented on September 3, 2024

@Rudra-sandeep the JSON has still problems:

  • Properties with different valueTypes have a value='' which is not None, it is string. In cases where valueType is not string it causes errors.
    Now:
                {
                  "category": "VARIABLE",
                  "idShort": "RecordCount",
                  "semanticId": {
                    "type": "ExternalReference",
                    "keys": [
                      {
                        "type": "GlobalReference",
                        "value": "https://admin-shell.io/idta/TimeSeries/Segment/RecordCount/1/1"
                      }
                    ]
                  },
                  "qualifiers": [
                    {
                      "type": "Cardinality",
                      "valueType": "xs:string",
                      "value": "ZeroToOne"
                    }
                  ],
                  "valueType": "xs:long",
                  "value": "",
                  "modelType": "Property"
                }

Should be:

                {
                  "category": "VARIABLE",
                  "idShort": "RecordCount",
                  "semanticId": {
                    "type": "ExternalReference",
                    "keys": [
                      {
                        "type": "GlobalReference",
                        "value": "https://admin-shell.io/idta/TimeSeries/Segment/RecordCount/1/1"
                      }
                    ]
                  },
                  "qualifiers": [
                    {
                      "type": "Cardinality",
                      "valueType": "xs:string",
                      "value": "ZeroToOne"
                    }
                  ],
                  "valueType": "xs:long",
                  "modelType": "Property"
                }
  • Also in cases where valueType is string and value is not set the value key should be just removed from property object.
  • File object also has an empty string as a value: "value": "". This also should be removed.

Tested with https://github.com/rwth-iat/basyx-python-sdk

from submodel-templates.

zrgt avatar zrgt commented on September 3, 2024

The problem also occures in Range object, as it has min and max values which should be removed or set to valid XSD datetime string

{
                "idShort": "Timespan",
                "description": [
                  {
                    "language": "en",
                    "text": "The valueType of the given timespan must match the valueType of the time properties of the segments."
                  }
                ],
                "semanticId": {
                  "type": "ExternalReference",
                  "keys": [
                    {
                      "type": "GlobalReference",
                      "value": "https://admin-shell.io/idta/TimeSeries/Timespan/1/1"
                    }
                  ]
                },
                "valueType": "xs:dateTime",
                "min": "",
                "max": "",
                "modelType": "Range"
              }

The same proble appears in DataSpecificationIec61360 with value:

{
            "preferredName": [
              {
                "language": "de",
                "text": "Zeitreihen Metadaten"
              },
              {
                "language": "en",
                "text": "time series metadata"
              }
            ],
            "shortName": [
              {
                "language": "de",
                "text": "Metadaten"
              },
              {
                "language": "en",
                "text": "metadata"
              }
            ],
            "definition": [
              {
                "language": "de",
                "text": "Eine Reihe von Daten, welche die Zeitreihe beschreiben und \u00FCber sie Auskunft geben"
              },
              {
                "language": "en",
                "text": "A set of data describing and providing information about the time series"
              }
            ],
            "value": "",
            "modelType": "DataSpecificationIec61360"
          }

from submodel-templates.

zrgt avatar zrgt commented on September 3, 2024

Also a problem in ExternalReference in semantiid of segments. According to Constraint AASd-122 the type of the first key of an ExternalReference must be a GenericGloballyIdentifiable, but "Property" was set:

            {
              "value": {
                "idShort": "Segments",
                "semanticId": {
                  "type": "ExternalReference",
                  "keys": [
                    {
                      "type": "Property",
                      "value": "https://admin-shell.io/idta/TimeSeries/AggregationMethod/1/1"
                    }
                  ]
                },
                "modelType": "SubmodelElementCollection"
              }
            }

from submodel-templates.

Rudra-sandeep avatar Rudra-sandeep commented on September 3, 2024

@zrgt Thank you for your feedback I will look into this issues.

from submodel-templates.

zrgt avatar zrgt commented on September 3, 2024

@Rudra-sandeep the same problems mentioned in the original issue report also appear in JSON.

from submodel-templates.

zrgt avatar zrgt commented on September 3, 2024

@zrgt Thank you for your feedback, I will look into this issue.

@Rudra-sandeep Please consider that probably all issues mentioned in this problem also exist in all JSON files that have been uploaded recently and the Serializer/SDK you are using is not compliant with the AAS Spec.

from submodel-templates.

Rudra-sandeep avatar Rudra-sandeep commented on September 3, 2024

@zrgt Thank you for your feedback, I will look into this issue.

@Rudra-sandeep Please consider that probably all issues mentioned in this problem also exist in all JSON files that have been uploaded recently and the Serializer/SDK you are using is not compliant with the AAS Spec.

@zrgt Yes regarding to compliant with the Spec we have already started discussions in the WG's

from submodel-templates.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.