add GetShouldBeClosed to BaseClient too about botcraft HOT 4 CLOSED

Also speaking of closing, there is issue with AFK client and well all of them: they don't detect disconnect very well, sometimes it just stays active and "connected" when in reality it is already not. Maybe a timeout by ping packets or at least method like "GetLastPingTime" to detect that client dropped connection

from botcraft.

There will be some modifications of all XXXClients with the new behaviour system (arriving soon-ish maybe perhaps I hope). I'll try to move the should_be_closed bool to a higher level in the hierarchy.

Concerning your second point, could you elaborate on how to reproduce this kind of disconnection? When the server kicks the player or when the connection is lost?

from botcraft.

I believe server just drops connection silently and does not even close socket. I experienced such "drops" on regular and hacked clients and both of them timeout after 30 seconds of last ping/tick from server, most likely considering socket dead.

from botcraft.

Fixed with the new Client organization

from botcraft.