Comments (5)
I agree the current naming scheme could be confusing and we can do more to improve it 👍
I personally don't mind us auto-selecting the correct task based on filetype but feel we're going to run into cases where .html/.htm aren't going to be sufficient signals. What should someone do if they're working against content with a different extension?
Let's leave this open in case we get some more feedback from the community. The proposed solution may well work out.
from critical.
What about adding inline
as an option for generate
, deprecate generateInline
and leave only the dest
option.
So we would only expose the generate
method and do inlining when the inline
option is set.
from critical.
Started another branch
This one is currently blocked by pocketjoso/penthouse#53
See: https://travis-ci.org/addyosmani/critical/jobs/59405654
from critical.
merged in master, so this could be closed
from critical.
This ticket took me a while to find, and it's good to know, but looking at the Critical Path CSS Demo makes it appear think styleTarget
and htmlTarget
are the way to go and not deprecated.
from critical.
Related Issues (20)
- Generated CSS is big HOT 8
- 'noscript)>[rel="stylesheet"]' is not a valid selector HOT 6
- Generate ciritical for multiple pages HOT 2
- Request: Add option to disable link media attribute wrapping HOT 1
- Rules within media queries duplicate when using multiple dimensions HOT 2
- Lots of css generated from below the fold
- Does not take redirects into account when looking for relative CSS HOT 2
- Does not take the <base HTML tag into account when looking for relative CSS HOT 7
- dimensions don't work HOT 2
- Error: Failed to launch the browser process! HOT 3
- typescript support ? HOT 1
- Add the option of a prefix path HOT 3
- On @container queries
- PageSpeed Insights consider CSS not deferred HOT 1
- Allowing internal functions to be imported HOT 3
- [✨] feat: Add the option of pass plain css HOT 2
- Several warnings appear when installing the latest version of critical HOT 3
- Resource Utilization
- 'punycode' is deprecated on node v.21 ERROR HOT 2
- HEAD requests are not using the provided request headers HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from critical.