Code Monkey home page Code Monkey logo

Comments (5)

addyosmani avatar addyosmani commented on July 18, 2024

I agree the current naming scheme could be confusing and we can do more to improve it 👍

I personally don't mind us auto-selecting the correct task based on filetype but feel we're going to run into cases where .html/.htm aren't going to be sufficient signals. What should someone do if they're working against content with a different extension?

Let's leave this open in case we get some more feedback from the community. The proposed solution may well work out.

from critical.

bezoerb avatar bezoerb commented on July 18, 2024

What about adding inline as an option for generate, deprecate generateInline and leave only the dest option.
So we would only expose the generate method and do inlining when the inline option is set.

from critical.

bezoerb avatar bezoerb commented on July 18, 2024

Started another branch
This one is currently blocked by pocketjoso/penthouse#53
See: https://travis-ci.org/addyosmani/critical/jobs/59405654

from critical.

bezoerb avatar bezoerb commented on July 18, 2024

merged in master, so this could be closed

from critical.

asuh avatar asuh commented on July 18, 2024

This ticket took me a while to find, and it's good to know, but looking at the Critical Path CSS Demo makes it appear think styleTarget and htmlTarget are the way to go and not deprecated.

from critical.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.