Comments (7)
Are you using https://github.com/addyosmani/critical-path-css-demo? Can you run rm -rf node_modules && npm cache clean
followed by npm install git://github.com/addyosmani/critical.git
and let us know if you run into the same issue?
@bezoerb I think some of our users are running into issues with the README/API changes introduced recently with the CLI updates. We might want to update https://github.com/addyosmani/critical-path-css-demo. I'll try to take a look this week.
from critical.
@propertunist can you try https://github.com/addyosmani/critical-path-css-demo? (updated)
from critical.
no, i'm not using the demo repo.. although i have looked at it.
i have saved an html file from my live site (which is originally generated via PHP) and am looking to process that page locally using critical.
from critical.
It's possible that there's something in the structure of your page that isn't correctly getting parsed in our pipeline or is causing a silent failure somewhere along the line. Is it possible to share a minimal version of your HTML and styles so we can take a look at what is causing breakage for you?
from critical.
sure, i downloaded the homepage from www.ureka.org as a complete file via firefox and applied critical to that html page locally.
from critical.
Tested against master
- downloaded homepage from www.ureka.org as a complete file
- put inlined styles in separate css files
- run
cat index.html | node ~/GitHub/critical/cli.js -im > test.html
Everthing went fine except that i was asked if phantomjs is allowed to access `https://assets.swarmcdn.com``
from critical.
ok i am v. busy here presently, but will come back to this asap. thanks
from critical.
Related Issues (20)
- critical just stucks at loading and does nothing HOT 2
- Remove query string from stylesheet path
- Print stylesheet unexpectedly gets `onload` attribute HOT 3
- Generated CSS is big HOT 8
- 'noscript)>[rel="stylesheet"]' is not a valid selector HOT 6
- Generate ciritical for multiple pages HOT 2
- Request: Add option to disable link media attribute wrapping HOT 1
- Rules within media queries duplicate when using multiple dimensions HOT 2
- Lots of css generated from below the fold
- Does not take redirects into account when looking for relative CSS HOT 2
- Does not take the <base HTML tag into account when looking for relative CSS HOT 7
- dimensions don't work HOT 2
- Error: Failed to launch the browser process! HOT 3
- typescript support ? HOT 1
- Add the option of a prefix path HOT 3
- On @container queries
- PageSpeed Insights consider CSS not deferred HOT 1
- Allowing internal functions to be imported HOT 3
- [✨] feat: Add the option of pass plain css HOT 2
- Several warnings appear when installing the latest version of critical HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from critical.