Code Monkey home page Code Monkey logo

Comments (7)

addyosmani avatar addyosmani commented on August 17, 2024

Are you using https://github.com/addyosmani/critical-path-css-demo? Can you run rm -rf node_modules && npm cache clean followed by npm install git://github.com/addyosmani/critical.git and let us know if you run into the same issue?

@bezoerb I think some of our users are running into issues with the README/API changes introduced recently with the CLI updates. We might want to update https://github.com/addyosmani/critical-path-css-demo. I'll try to take a look this week.

from critical.

addyosmani avatar addyosmani commented on August 17, 2024

@propertunist can you try https://github.com/addyosmani/critical-path-css-demo? (updated)

from critical.

propertunist avatar propertunist commented on August 17, 2024

no, i'm not using the demo repo.. although i have looked at it.
i have saved an html file from my live site (which is originally generated via PHP) and am looking to process that page locally using critical.

from critical.

addyosmani avatar addyosmani commented on August 17, 2024

It's possible that there's something in the structure of your page that isn't correctly getting parsed in our pipeline or is causing a silent failure somewhere along the line. Is it possible to share a minimal version of your HTML and styles so we can take a look at what is causing breakage for you?

from critical.

propertunist avatar propertunist commented on August 17, 2024

sure, i downloaded the homepage from www.ureka.org as a complete file via firefox and applied critical to that html page locally.

from critical.

bezoerb avatar bezoerb commented on August 17, 2024

Tested against master

  • downloaded homepage from www.ureka.org as a complete file
  • put inlined styles in separate css files
  • run cat index.html | node ~/GitHub/critical/cli.js -im > test.html

Everthing went fine except that i was asked if phantomjs is allowed to access `https://assets.swarmcdn.com``

from critical.

propertunist avatar propertunist commented on August 17, 2024

ok i am v. busy here presently, but will come back to this asap. thanks

from critical.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.