Backslashes in output url()s on Windows about critical HOT 9 CLOSED

@bezoerb It would be great to update our tests to account for any URL changes once we've figured out how to safely avoid accidental path translations. Are you able to verify this change in path occurs?

from critical.

Fixed the issue using slash
@addyosmani any chance for running automated tests on windows machines?

from critical.

btw, all unit tests were green on my windows 7 vm after adding the fix.

from critical.

Perfect. Just one question: wouldn't it be safer to use path.sep in the condition rather than process.platform?

from critical.

I wonder if this is something we could setup via Travis at all. I'll explore it, but good to hear tests are green post-fix.

from critical.

ping @bezoerb re: question above.

from critical.

@addyosmani @r-flash sorry for the delay.
path.sep internally depends on process.platform so it makes no difference.
See https://github.com/joyent/node/blob/master/lib/path.js#L23

from critical.

@addyosmani I've just configured appveyor to run tests on windows but it looks like they don't start automatically. I think you need to add the following webhook for push and on pull request to critical:
https://ci.appveyor.com/api/github/webhook?id=cn6jw7r3ur0gmyg6

from critical.

@addyosmani added you as admin to the appveyor project

from critical.