Comments (9)
@bezoerb It would be great to update our tests to account for any URL changes once we've figured out how to safely avoid accidental path translations. Are you able to verify this change in path occurs?
from critical.
Fixed the issue using slash
@addyosmani any chance for running automated tests on windows machines?
from critical.
btw, all unit tests were green on my windows 7 vm after adding the fix.
from critical.
Perfect. Just one question: wouldn't it be safer to use path.sep in the condition rather than process.platform?
from critical.
I wonder if this is something we could setup via Travis at all. I'll explore it, but good to hear tests are green post-fix.
from critical.
ping @bezoerb re: question above.
from critical.
@addyosmani @r-flash sorry for the delay.
path.sep
internally depends on process.platform
so it makes no difference.
See https://github.com/joyent/node/blob/master/lib/path.js#L23
from critical.
@addyosmani I've just configured appveyor to run tests on windows but it looks like they don't start automatically. I think you need to add the following webhook for push
and on pull request
to critical:
https://ci.appveyor.com/api/github/webhook?id=cn6jw7r3ur0gmyg6
from critical.
@addyosmani added you as admin to the appveyor
project
from critical.
Related Issues (20)
- 'noscript)>[rel="stylesheet"]' is not a valid selector HOT 6
- Generate ciritical for multiple pages HOT 2
- Request: Add option to disable link media attribute wrapping HOT 1
- Rules within media queries duplicate when using multiple dimensions HOT 2
- Lots of css generated from below the fold
- Does not take redirects into account when looking for relative CSS HOT 2
- Does not take the <base HTML tag into account when looking for relative CSS HOT 7
- dimensions don't work HOT 2
- Error: Failed to launch the browser process! HOT 3
- typescript support ? HOT 1
- Add the option of a prefix path HOT 3
- On @container queries
- PageSpeed Insights consider CSS not deferred HOT 1
- Allowing internal functions to be imported HOT 3
- [✨] feat: Add the option of pass plain css HOT 2
- Several warnings appear when installing the latest version of critical HOT 3
- Resource Utilization
- 'punycode' is deprecated on node v.21 ERROR HOT 2
- HEAD requests are not using the provided request headers HOT 7
- Not working on Almalinux 9, without GUI. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from critical.