Undesired rewriting of import statements (pre-commit loop) about django-upgrade HOT 6 CLOSED

The import should only be added if something else in the file needs it - can you see any URL's that are being modified as well?

from django-upgrade.

Nothing else is being modified.

I believe this happens:

1. I ran precommit run django-upgrade --all-files and initially, things were modified such that the new import statements made sense together with URL pattern changes
2. Upon "git commit", I see that subsequent pre-commit hooks make additional changes
3. I commit the changes made by pre-commit but since django-upgrade is ALSO installed as a pre-commit, I now see that it has made new import statement changes as described above (but nothing else got changed)

from django-upgrade.

Thanks, replicated with an extra test in test_django_urls.py:

def test_two_imported_used():
    check_noop(
        """\
        from django.urls import path
        from django.urls import re_path

        path('whatever')
        re_path('whatever')
        """,
        settings,
    )

The problem is that the call-rewriter is registering re_path as "used" when it encounters it (even though it doesn't rewrite it to path), which makes the import-rewriter rewrite it.

I think the import rewriting code here could do with some improvements to support all import styles.

from django-upgrade.

The same issue is happening for us.

We are also using one line per import and the library is rewriting the import and then isort rewrite it back.

Means we cannot use this pre-commit until the issue is fixed.

from django-upgrade.

Understood, I started lookign a fix in #255, treating it as a release blocker at least.

from django-upgrade.

Thank you for the update @adamchainz 👍

from django-upgrade.