Comments (3)
Month can't be 60 right? It's Month = 0 and Day = 60, I think.
We also need to update the CoordinationNumber test-data to include numbers with month=0 and day=60, and remove numbers with days > DaysInMonth.
We should be able to handle the hints as you suggest.
from activelogin.identity.
Also, I think there still is a missing requirement, but I am not sure if we can extract any more information from Skatteverket unless we want to end up on some list for blocked emails ;)
This is just an edge case, so maybe we can decide on it ourselves:
For a coordination day the valid MIN is 60.
For a coordination day the valid MAX is 60 + (DaysInMonth for month n
). (where n
is 1-12).
For a coordination day the valid MAX is ?? when month is 0.
Or have they actually confirmed that the only valid day is 60 if month is 0? I.e. can you know the day of birth, but not the month?
We can't be too strict here, because it could mean that we could parse a (potentially) valid coordination number as invalid, so without further input from Skatteverket I think we need to allow for any day number 60-91 if the month is 0.
from activelogin.identity.
Month can't be 60 right? It's Month = 0 and Day = 60, I think.
Correct!
We also need to update the CoordinationNumber test-data to include numbers with month=0 and day=60, and remove numbers with days > DaysInMonth.
Yes!
We can't be too strict here, because it could mean that we could parse a (potentially) valid coordination number as invalid, so without further input from Skatteverket I think we need to allow for any day number 60-91 if the month is 0.
I think you are right - After the numerous emails just to get here I'm quite sure this isn't specified. I agree that we should not be too strict here.
from activelogin.identity.
Related Issues (20)
- Add support for Finnish personal identity number HOT 1
- Packaging Documentation within the nupkg HOT 1
- Restructure samples HOT 2
- Dealing with too long README.md HOT 1
- Add tests for InvididualIdentityNumber HOT 1
- Remove FSharp API
- Remove Swedish-prefix from type names
- Update readme with respect to the new fsharp api
- Inequality operator not working as expected in C#
- Remove internal DomainError-types
- Create package with extensions for adding Testdata to Bogus HOT 2
- C# testdata returns FSharpList HOT 2
- Move SwedishPersonalIdentityNumberTestDataExtensions to the ActiveLogin.Identity.Swedish namespace
- Investigate serialization support HOT 3
- TestData causes docker container to crash
- Data validation in forms, data imports or similar HOT 10
- Unit test bug: For testing strict mode new invalid test data generators are needed
- CoordinationNumber does not exist in the nuget package? HOT 5
- Add new test numbers to the TestData nuget package HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from activelogin.identity.