Code Monkey home page Code Monkey logo

Comments (3)

viktorvan avatar viktorvan commented on June 9, 2024

Month can't be 60 right? It's Month = 0 and Day = 60, I think.

We also need to update the CoordinationNumber test-data to include numbers with month=0 and day=60, and remove numbers with days > DaysInMonth.

We should be able to handle the hints as you suggest.

from activelogin.identity.

viktorvan avatar viktorvan commented on June 9, 2024

Also, I think there still is a missing requirement, but I am not sure if we can extract any more information from Skatteverket unless we want to end up on some list for blocked emails ;)

This is just an edge case, so maybe we can decide on it ourselves:

For a coordination day the valid MIN is 60.
For a coordination day the valid MAX is 60 + (DaysInMonth for month n). (where n is 1-12).
For a coordination day the valid MAX is ?? when month is 0.

Or have they actually confirmed that the only valid day is 60 if month is 0? I.e. can you know the day of birth, but not the month?

We can't be too strict here, because it could mean that we could parse a (potentially) valid coordination number as invalid, so without further input from Skatteverket I think we need to allow for any day number 60-91 if the month is 0.

from activelogin.identity.

PeterOrneholm avatar PeterOrneholm commented on June 9, 2024

Month can't be 60 right? It's Month = 0 and Day = 60, I think.

Correct!

We also need to update the CoordinationNumber test-data to include numbers with month=0 and day=60, and remove numbers with days > DaysInMonth.

Yes!

We can't be too strict here, because it could mean that we could parse a (potentially) valid coordination number as invalid, so without further input from Skatteverket I think we need to allow for any day number 60-91 if the month is 0.

I think you are right - After the numerous emails just to get here I'm quite sure this isn't specified. I agree that we should not be too strict here.

from activelogin.identity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.