Code Monkey home page Code Monkey logo

Comments (2)

javierjulio avatar javierjulio commented on May 28, 2024 1

Several problems here. Others have had the same reaction but importmap-rails has made it clear to not pin from node_modules directory. We should be able to resolve this for Rails 7.1 since it includes rails-ujs in ESM format but earlier versions don't by updating our Importmap config to pin that file directly. For earlier Rails versions though I don't know what to do. I'd like to vendor the file but from my testing I can't get the pin to override the default rails-ujs lookup so meaning on Rails 7.0, it will retrieve a non-ESM gem-bundled version.

from activeadmin.

javierjulio avatar javierjulio commented on May 28, 2024 1

@tagliala when I started this I was going off of the importmap-rails docs that were incorrect and later updated. That was causing me some grief with this since I did try vendoring the file which I think is best. I've tried again after seeing that recent docs change earlier this week and pinning the @rails/ujs to a vendor file now does work and uses the file provided rather than what is bundled in the Rails gem. I'll have an update for that.

from activeadmin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.