Code Monkey home page Code Monkey logo

Comments (7)

yoannchaudet avatar yoannchaudet commented on May 27, 2024 3

I don't have an ETA yet because we are still planning for it but just a heads up that we are prioritizing this work.

from deploy-pages.

yoannchaudet avatar yoannchaudet commented on May 27, 2024

👋 That's more of an Actions problem. What is missing is the concept of protected tags on environments.

image

We cannot allow Pages deployments on non-protected environments (this is our security paradigm for Actions based deployments).

No ETA yet but we will be adding support for that.

A workaround for now could be to have two workflows:

  • A first one that runs on tag creation like you have, run a build and push content to a branch
  • A second one that does the deployment from the branch

from deploy-pages.

cqc-alec avatar cqc-alec commented on May 27, 2024

I have a similar workflow; this would be a very useful feature.

Regarding the suggested workaround, doesn't this have all the disadvantages of the old gh-pages method (filling a branch with generated content, blowing up the size of the repo, etc)?

from deploy-pages.

yoannchaudet avatar yoannchaudet commented on May 27, 2024

That's why it's called a workaround 😅

from deploy-pages.

till avatar till commented on May 27, 2024

@yoannchaudet is it enough to break this into two workflows?

E.g. I use upload-pages-artifact with a workflow that runs on on.push.tags and then start/trigger another workflow once that completes?

I was thinking, or on.workflow_dispatch or something like a on.workflow_run (with types: ["completed"] filter).

from deploy-pages.

yoannchaudet avatar yoannchaudet commented on May 27, 2024

We made changes to the security validation a while back. You should be able to deploy from tags now. With the caveat that you have to drop the environment protection rules. Check #151 (comment).

from deploy-pages.

till avatar till commented on May 27, 2024

@yoannchaudet Amaze! It worked. 🎉

For whoever else needs it, I ended up with a variation of this starter workflow as I had to trigger jekyll as well now.

TL;DR — do my release in one job and then start another with the correct token permissions to update the page.

from deploy-pages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.