Comments (7)
I don't have an ETA yet because we are still planning for it but just a heads up that we are prioritizing this work.
from deploy-pages.
👋 That's more of an Actions problem. What is missing is the concept of protected tags on environments.
We cannot allow Pages deployments on non-protected environments (this is our security paradigm for Actions based deployments).
No ETA yet but we will be adding support for that.
A workaround for now could be to have two workflows:
- A first one that runs on tag creation like you have, run a build and push content to a branch
- A second one that does the deployment from the branch
from deploy-pages.
I have a similar workflow; this would be a very useful feature.
Regarding the suggested workaround, doesn't this have all the disadvantages of the old gh-pages
method (filling a branch with generated content, blowing up the size of the repo, etc)?
from deploy-pages.
That's why it's called a workaround 😅
from deploy-pages.
@yoannchaudet is it enough to break this into two workflows?
E.g. I use upload-pages-artifact with a workflow that runs on on.push.tags
and then start/trigger another workflow once that completes?
I was thinking, or on.workflow_dispatch
or something like a on.workflow_run
(with types: ["completed"]
filter).
from deploy-pages.
We made changes to the security validation a while back. You should be able to deploy from tags now. With the caveat that you have to drop the environment protection rules. Check #151 (comment).
from deploy-pages.
@yoannchaudet Amaze! It worked. 🎉
For whoever else needs it, I ended up with a variation of this starter workflow as I had to trigger jekyll as well now.
TL;DR — do my release in one job and then start another with the correct token permissions to update the page.
from deploy-pages.
Related Issues (20)
- Is there a way to use this in the composite action? HOT 3
- [QUESTION] Is it possible to deploy a single file without losing existent files? HOT 1
- Actions fail after update actions/deploy-pages to v4 and actions/upload-pages-artifact to v3 HOT 17
- Failing to fetch artifact metadata since 4.0.0 HOT 8
- Bump to V4 broke the deploy step HOT 9
- Remove requirement for `actions: read` permission HOT 1
- Unhelpful Error HOT 5
- Page Deployment Failing Periodically with Timeouts since Upgrade to v4 HOT 1
- Getting "Fetching artifact metadata failed." HOT 3
- Confusing error when trying to deploy Rust docs HOT 6
- CNAME file doesn't work to set custom domain
- Error: No artifacts named "github-pages" were found for this workflow run. HOT 5
- Deploy to another repository HOT 2
- GitHub Enterprise Server 3.11.5 compatibility HOT 6
- Deployment protection rules seem to be ignored HOT 1
- 502 error on github enterprise HOT 3
- More clarity on id-token: write HOT 11
- Artifact could not be deployed; no symlinks or hard links, small size HOT 1
- When the preview feature will be available
- Allow deploy by artifact_id
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deploy-pages.