`error_count` input name is confusing about deploy-pages HOT 6 OPEN

There's a brief parameter description included in the Action manifest:

Fair misunderstanding, especially since we shouldn't really allow error_count: 0. That causes the action to fail even if there are 0 errors when it does the check. 😅 🤦

The behavior you're describing would be achieved by error_count: 1, as in "fail on the first error".

I see you also found a similar write-up in:

• #172 (comment)

We may consider revising the naming but, for now, error_count: 1 achieves the desired behavior.

Apologies for the confusion! ❤

from deploy-pages.

Thanks, makes sense.

It's the good old "threshold problem". Over at detekt we also had similar problems and they're being renamed in the upcoming major to clarify.

I'm curious if this issue will get more upvotes in the coming year, especially if/when this upload approach goes out of beta and adoption grows.

from deploy-pages.

I'm curious if this issue will get more upvotes in the coming year, especially if/when this upload approach goes out of beta and adoption grows.

Oh, we're waaaaay out of beta. 😅 This action is involved in more than 2 million Pages deployments per week.

We might be open to renaming the parameter in a future major release, though. 🤷
Any naming suggestions?

from deploy-pages.

I was referring to this "Beta":

I think you said it best

error_count: 1, as in "fail on the first error".

i.e. fail_on_error_count: 5

I think maybe: allowed_status_failures: 4 would be an even better name. But it implies that during migration users have to subtract one from their config. Default can stay as it doesn't really matter if it fails on 10th or 11th.

Another alternative could be status_report_retries: 4.

from deploy-pages.

Sorry to be wishy-washy, but I'm going to reopen this so the feedback isn't lost. 😅

from deploy-pages.

Sorry to be wishy-washy, but I'm going to reopen this so the feedback isn't lost. 😅

Up to you how to handle this. Feedback is a weird thing, it's not always actionable 😇

from deploy-pages.