Comments (6)
There's a brief parameter description included in the Action manifest:
Lines 16 to 17 in 03b62d1
Fair misunderstanding, especially since we shouldn't really allow error_count: 0
. That causes the action to fail even if there are 0 errors when it does the check. 😅 🤦
The behavior you're describing would be achieved by error_count: 1
, as in "fail on the first error".
I see you also found a similar write-up in:
We may consider revising the naming but, for now, error_count: 1
achieves the desired behavior.
Apologies for the confusion! ❤
from deploy-pages.
Thanks, makes sense.
It's the good old "threshold problem". Over at detekt we also had similar problems and they're being renamed in the upcoming major to clarify.
I'm curious if this issue will get more upvotes in the coming year, especially if/when this upload approach goes out of beta and adoption grows.
from deploy-pages.
I'm curious if this issue will get more upvotes in the coming year, especially if/when this upload approach goes out of beta and adoption grows.
Oh, we're waaaaay out of beta. 😅 This action is involved in more than 2 million Pages deployments per week.
We might be open to renaming the parameter in a future major release, though. 🤷
Any naming suggestions?
from deploy-pages.
I was referring to this "Beta":
I think you said it best
error_count: 1, as in "fail on the first error".
i.e. fail_on_error_count: 5
I think maybe: allowed_status_failures: 4
would be an even better name. But it implies that during migration users have to subtract one from their config. Default can stay as it doesn't really matter if it fails on 10th or 11th.
Another alternative could be status_report_retries: 4
.
from deploy-pages.
Sorry to be wishy-washy, but I'm going to reopen this so the feedback isn't lost. 😅
from deploy-pages.
Sorry to be wishy-washy, but I'm going to reopen this so the feedback isn't lost. 😅
Up to you how to handle this. Feedback is a weird thing, it's not always actionable 😇
from deploy-pages.
Related Issues (20)
- Bump to V4 broke the deploy step HOT 9
- Remove requirement for `actions: read` permission HOT 1
- Unhelpful Error HOT 5
- Page Deployment Failing Periodically with Timeouts since Upgrade to v4 HOT 1
- Getting "Fetching artifact metadata failed." HOT 3
- Confusing error when trying to deploy Rust docs HOT 7
- CNAME file doesn't work to set custom domain
- Error: No artifacts named "github-pages" were found for this workflow run. HOT 5
- Deploy to another repository HOT 2
- GitHub Enterprise Server 3.11.5 compatibility HOT 6
- Deployment protection rules seem to be ignored HOT 1
- 502 error on github enterprise HOT 3
- More clarity on id-token: write HOT 13
- Artifact could not be deployed; no symlinks or hard links, small size HOT 1
- When the preview feature will be available HOT 3
- Allow deploy by artifact_id
- Problem in page deployment with vuejs vite to github page HOT 8
- Value 'github-pages' is not valid HOT 6
- Astro Site: Please ensure the content does not contain any hard links, symlinks and total size is less than 10GB HOT 2
- Feature request: Partial upload/deploy
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deploy-pages.