acquia / drupal-recommended-project Goto Github PK

Recommended Drupal project for use on Acquia Cloud

License: GNU General Public License v2.0

drupal-recommended-project's Introduction

Acquia Drupal Recommended Project

This is a project template providing a great out-of-the-box experience for new Drupal 11 projects hosted on Acquia. It is based on the Drupal Recommended Project, with the principal difference being the addition of several modules and packages that provide the best possible out-of-the-box experience for Acquia customers.

This project includes the following packages and configurations:

Drupal core
Drupal core scaffold
Acquia CMS (Starter kit)
Drupal Recommended Settings
Drush (Drupal CLI and development tool)
Asset Packagist repository, package, and configuration
Acquia environment detection
Acquia platform memcache settings
Best practices for Drupal development, testing and project architecture

The Acquia CMS Starterkit allows you to install Drupal for a given style of CMS:

Name	Description
Acquia CMS Enterprise Low-code	The low-code starter kit will install Acquia CMS with Site Studio and a UIkit. It provides drag and drop content authoring and low-code site building. An optional content model can be added in the installation process.
Acquia CMS Community	The community starter kit will install Acquia CMS. An optional content model can be added in the installation process.
Acquia CMS Headless	The headless starter kit preconfigures Drupal for serving structured, RESTful content to 3rd party content displays such as mobile apps, smart displays and frontend driven websites (e.g. React or Next.js).

For more information on selecting the Acquia CMS Starterkit that best fits your use case follow instructions.

Installation

Create a new project using Composer:

composer create-project --no-interaction acquia/drupal-recommended-project

Once you create the project, you can and should customize composer.json and the rest of the project to suit your needs. You will receive updates from any dependent packages, but not from the project template itself. It's yours to keep!

For instance, you can remove a provided package by running the following command and committing the changed composer.json and composer.lock to Git:

composer remove acquia/mysql56

You should only commit changes to composer.json and composer.lock. Do not commit files in the vendor, docroot/core, and similar directories (these are ignored by the provided .gitignore file). In order to run your application in another environment, you’ll need to run composer install to reinstall these assets. Acquia Code Studio’s Auto DevOps feature can do this automatically when deploying to Acquia Cloud.

Usage (Install Acquia CMS)

Install Acquia CMS using starterkit follow instructions.

Other Drupal versions

Drupal 11 is installed by default. To install Drupal 10, use the below command:

composer create-project acquia/drupal-recommended-project:^2

To install Drupal 9, use the below command:

composer create-project acquia/drupal-recommended-project:^1

License

This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License version 2 as published by the Free Software Foundation.

This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.

drupal-recommended-project's People

Contributors

Stargazers

Watchers

drupal-recommended-project's Issues

Drupal Recommended Project Ships .travis.yml

When creating a new project with drupal-recommended-project I got the .travis.yml file. This should be export-ignored via a .gitattributes file so it doesn't get distributed when people composer create w/ the project.

Bump Drush to 11.x

see acquia/blt#4464

ACMS-1941: Fatal errors thrown by SubtypeBreadcrumb

Describe the bug
I was getting a fatal error while trying to view an event node that had been created as part of the demo content:

Error: Call to a member function getPath() on null in Drupal\acquia_cms_common\SubtypeBreadcrumb->getListPageLink() (line 180 of /var/www/html/docroot/modules/contrib/acquia_cms_common/src/SubtypeBreadcrumb.php).

The SubtypeBreadcrumb throws multiple fatal errors. The error above happens because the getListPageLink tests internally if the facet source is an instance of SearchApiFacetSourceInterface but can't return a properly constructed link if not. For this, I would propose wrapping the the call to this method in the build method, in a check that the facet source is the expected instance type.

With that fixed, I now get a new error:

Error: Call to a member function getPath() on null in Drupal\facets_pretty_paths\Plugin\facets\url_processor\FacetsPrettyPathsUrlProcessor->buildUrls() (line 165 of /var/www/html/docroot/modules/contrib/facets_pretty_paths/src/Plugin/facets/url_processor/FacetsPrettyPathsUrlProcessor.php).

I had installed demo content and then replaced the standard ACMS Event views with those from the Smart Date Starter Kit and Smart Date Calendar Kit, which I suspect is related to the errors. That said, the code should be able to handle unexpected output without fatal errors.

The CI is failing due to latest release of `ergebnis/composer-normalize`

Describe the bug
The Static Code Analysis CI job is failing due to latest release of ergebnis/composer-normalize. ORCA updated the minimum required dependencies for ergebnis/composer-normalize plugin, due to which Static Code Analysis CI is failing.

To Reproduce
Run the below commands and you would see composer normalize error i.e

git clone [email protected]:acquia/drupal-recommended-project.git --branch=master project && cd project
composer require "ergebnis/composer-normalize:^2.30.2"
./vendor/bin/composer '--ansi' '--dry-run' 'normalize' '--indent-size=4' '--indent-style=space' ${PWD}/composer.json

Expected behavior
The CI job should pass without reporting any errors.

Additional context
https://github.com/acquia/drupal-recommended-project/actions/runs/9278136563

Add Acquia settings include

Customers who do not use BLT must manually add a settings include line to their acquia/drupal-recommended-project application. I'd like to remove this requirement by adding the following to settings.php by default:

if (file_exists('/var/www/site-php')) {
  require "/var/www/site-php/{$_ENV['AH_SITE_GROUP']}/{$_ENV['AH_SITE_GROUP']}-settings.inc";
}

This could be accomplished in a few ways.

DX-5131: Remove acquia/acquia_cms in favour of Acquia CMS Starter kit

We are releasing the stable release of Acquia CMS v2.0.0. With Acquia CMS v2.0.0, the Acquia CMS is no longer a Drupal distribution. The recommended way of using Acquia CMS is now changed. We are now providing the Acquia CMS Starter kit CLI tool.
The user's would just need to run the following command:

./vendor/bin/acms acms:install

Then CLI tool will present the different options (we call it as Starter kits) and they can chose any of the starter kit based on their needs.
Depending on the starter kit selection, the CLI tool would do the following:

Ask the additional questions (Ex: If user needs to include content model, starter content etc.).
Ask for the credentials, if needed by the starter kit (Ex: Google Maps key, Site Studio credentials etc.).
Downloads all the recommended Acquia CMS modules required by the user selected starter kit.
Install the Drupal site.
Install & enable the modules/themes/packages needed by the starter kit.

ACMS-1708: The github release drafter creating empty releases for 2.x branch.

The Github release drafter is creating empty releases for 2.x branch and also releasing it. For 1.x branch, release drafter is creating empty releases, but it's not releasing it and showing as draft.

DX-5151: Require PHP 8.1

We currently support PHP 7.4-8.1. I think there's a reasonable argument to be made that if you're setting up a new project, you must use the latest version of PHP (8.1). This would make maintenance marginally simpler and fix a cross-compatibility with ORCA and Drupal 10, which only supports PHP 8.1.

DX-5162: test jira integration

DX-5107: Create a new branch for ACMS V2 testing

Please create a branch on acquia/drupal-recommended-projectthat removesacquia/acquia_cmsand addsAcquia/acquia-cms-starterkit`

We want to test ACMS V2 versions via the drupal-recommended-project.

Please note this is under development and not meant to be used by anyone else outside of Acquia, so I am not sure if there are any specific perms to be managed.

Thank you!

DX-5138: EOL for Drupal Minimal Project, move extra config options to ACMS

In the near future ACMS v2 will change how sites are installed to use a CLI wizard rather than getting all functionality out of the box. This could allow us to EOL the Drupal Minimal Project since the main difference between Drupal Minimal and Recommended projects is the number of Composer packages required, and with ACMS v2 OOTB you get no additional packages.

If we move some of the supporting files and templates (phpunit config, example tests, etc) to ACMS via CLI options, then Drupal Recommended Project essentially becomes a minimal project, and all the additional functionality comes via CLI options.

Killing Drupal Mimimal Project is good because it will simplify the onboarding customer journey and reduce the potential for confusion.

Here's the feature branch to switch to ACMS v2: https://github.com/acquia/drupal-recommended-project/tree/113-acms-v2

Need to coordinate this as a major release with ORCA

Change release-drafter/release-drafter action to 6

The latest release of action release-drafter/release-drafter is 6 and currently we are using 5. So, update github action version of release-drafter/release-drafter from 5 to 6.

DX-5132: D10 testing branch

Given the upcoming release of Drupal 10, it would be good to have a feature branch of the project template supporting Drupal 10 that people can use to test.

ACMS-1648: Remove scaffolding for the files already done by drupal/core

Noticed that scaffolding done here https://github.com/acquia/drupal-recommended-project/blob/master/composer.json#L59-L68 is already perform by drupal core.

Also in latest version of acquia cms we don't use it as profiles hence below code can be removed
https://github.com/acquia/drupal-recommended-project/blob/master/composer.json#L71-L74

ACMS-3950: Support Drupal 11

As a developer,
I want to use Drupal 11 using acquia/drupal-recommended-project,
So that we can ensure compatibility and readiness for the upcoming Drupal 11 release.

Acceptance Criteria:

When creating a new project using acquia/drupal-recommended-project, Drupal 11 should be downloaded automatically.
When installing a site using the project, the installation process should be successful without encountering any errors.

Approach:

Remove the following packages that do not support Drupal 11 or have conflicting dependencies:
- acquia/acquia-cms-starterkit
- acquia/drupal-recommended-settings
- acquia/memcache-settings
- drupal/config_sync_without_site_uuid
  Once above packages support Drupal 11 or resolve their conflicts, we can be add them back.
Update the following packages to versions compatible with Drupal 11:

drupal/core-composer-scaffold:^11
drupal/core-recommended:^11
drush/drush:^13

Update the composer PHP platform config to 8.3 as required by Drupal 11.
Adjust the ORCA workflow to ensure CI runs on Drupal 11.

Testing Required

Manual testing.

DX-5123: Update composer to use stability version for acquia/acquia-cms-starterkit

We need to update composer dependency to use stability version constraint for acquia/acquia_cms-starterkit repo in branch 113-acms-v2.

Proposed changes:

diff --git a/composer.json b/composer.json
index f93f5d4..9a2177d 100644
--- a/composer.json
+++ b/composer.json
@@ -11,7 +11,7 @@
     ],
     "require": {
         "php": ">=7.4",
-        "acquia/acquia-cms-starterkit": "*",
+        "acquia/acquia-cms-starterkit": "^1.0",

[Feature request] Add reference to Drupal 9 Spec Tool

It is Acquia best practice for Drupal builds to use the Drupal Spec tool. For Drupal 9 specifically, ^4.0.0 should be used.

Since the drupal-recommended-project does not support behat out-of-the-box, it does not make sense to include the Drupal Spec Tool package in composer.json. (The package is dependent on behat, and in general just hooks the Drupal Spec Sheet spreadsheet into behat.) However, it does make sense to reference the Drupal Spec Tool spreadsheet in this project.

DX-5157: Running acms:install fails because database has not been configured

I ran the following:

php vendor/bin/acms acms:install acquia_cms_enterprise_low_code --no-interaction

The process crashed because no database settings have been configured.

Installing Site:
----------------
> './vendor/bin/drush' 'site:install' 'minimal' '--site-name=Acquia CMS Enterprise Low-code' '--yes'
 [warning] Program mysql not found. Proceed if you have already created or emptied the Drupal database.

 You are about to:
 * Create a sites/default/settings.php file

 // Do you want to continue?: yes.

 [notice] Starting Drupal installation. This takes a while.
 [notice] Performed install task: install_select_language
 [notice] Performed install task: install_select_profile
 [notice] Performed install task: install_load_profile
 [notice] Performed install task: install_verify_requirements

In install.core.inc line 971:

  Resolve all issues below to continue the installation. For help configuring your database server, see the <a href="https://www.drupal.org/docs/8/install">installation handbook</a>, or contact your hosting provider.<div class
  ="item-list"><ul><li>Failed to connect to your database server. The server reports the following message: <em class="placeholder">SQLSTATE[HY000] [2002] Connection refused</em>.<ul><li>Is the database server running?</li><li
  >Does the database exist or does the database user have sufficient privileges to create the database?</li><li>Have you entered the correct database name?</li><li>Have you entered the correct username and password?</li><li>Ha
  ve you entered the correct database hostname and port number?</li></ul></li></ul></div>

DX-5104: Document that Drupal and modules are in the .gitignore file

When someone (say, a customer) creates a new project from scratch in an IDE using acquia/drupal-recommend-project as the basis for it, they cannot add all of the Drupal-related files to their Git repository unless they remove the lines from the .gitignore file. Can we include in the README a note about that?

Include acquia/drupal-recommended-settings project

Include acquia/drupal-recommended-settings project so that customer using the acquia/drupal-recommended-project doesn't need to manually make any changes in their settings.php before installing site Acquia Cloud/Cloud IDE/local etc.

Project create for Drupal 9 (BLT Version) fails to create database

Description

Failure to install Drupal for fin project create and selecting number 2. Drupal 9 (BLT Version).

Steps to reproduce the issue:

fin project create
Select 2. Drupal 9 (BLT Version)

Describe the results you received:

Fails to create database. It recommends creating it manually. Which I did, and I ran fin init to only be met with the sam error.

Describe the results you expected:

Database should be created on project create.

Output of fin config:

fin config output

---------------------
COMPOSE_PROJECT_NAME_SAFE: bltd9
COMPOSE_FILE:
/Users/user/.docksal/stacks/volumes-nfs.yml
/Users/user/.docksal/stacks/stack-default.yml
/Users/user/Projects/bltd9/.docksal/docksal.yml
ENV_FILE:
/Users/user/Projects/bltd9/.docksal/docksal.env

PROJECT_ROOT: /Users/user/Projects/bltd9
DOCROOT: docroot
VIRTUAL_HOST: bltd9.docksal
VIRTUAL_HOST_ALIASES: *.bltd9.docksal
IP: 192.168.64.100
MYSQL: 192.168.64.100:32768

Docker Compose configuration
---------------------
services:
  cli:
    dns:
    - 192.168.64.100
    - 8.8.8.8
    environment:
      BLACKFIRE_CLIENT_ID: null
      BLACKFIRE_CLIENT_TOKEN: null
      COMPOSER_ALLOW_XDEBUG: '0'
      COMPOSER_DEFAULT_VERSION: null
      COMPOSER_DISABLE_XDEBUG_WARN: '0'
      DOCROOT: docroot
      DRUSH_ALLOW_XDEBUG: '0'
      DRUSH_OPTIONS_URI: bltd9.docksal
      GIT_USER_EMAIL: [email protected]
      GIT_USER_NAME: John Doe
      HOST_GID: '20'
      HOST_UID: '502'
      MYSQL_DATABASE: default
      MYSQL_HOST: db
      MYSQL_PASSWORD: user
      MYSQL_ROOT_PASSWORD: root
      MYSQL_USER: user
      PHP_IDE_CONFIG: null
      SECRET_ACAPI_EMAIL: null
      SECRET_ACAPI_KEY: null
      SECRET_ACQUIACLI_KEY: retracted
      SECRET_ACQUIACLI_SECRET: retracted
      SECRET_PLATFORMSH_CLI_TOKEN: null
      SECRET_SSH_PRIVATE_KEY: null
      SECRET_TERMINUS_TOKEN: null
      SSH_AUTH_SOCK: /.ssh-agent/proxy-socket
      VIRTUAL_HOST: bltd9.docksal
      XDEBUG_CONFIG: remote_connect_back=0 remote_host=192.168.64.1
      XDEBUG_ENABLED: '0'
    healthcheck:
      interval: 10s
    hostname: cli
    image: docksal/cli:2.12-php7.3
    labels:
      io.docksal.shell: bash
      io.docksal.user: docker
    logging:
      options:
        max-file: '10'
        max-size: 1m
    volumes:
    - docksal_ssh_agent:/.ssh-agent:ro
    - cli_home:/home/docker:rw
    - /tmp/.docksal/bltd9:/tmp/.docksal/bltd9:ro
    - project_root:/var/www:rw,nocopy,cached
  db:
    dns:
    - 192.168.64.100
    - 8.8.8.8
    environment:
      MYSQL_ALLOW_EMPTY_PASSWORD: null
      MYSQL_DATABASE: default
      MYSQL_INITDB_SKIP_TZINFO: null
      MYSQL_ONETIME_PASSWORD: null
      MYSQL_PASSWORD: user
      MYSQL_RANDOM_ROOT_PASSWORD: null
      MYSQL_ROOT_PASSWORD: root
      MYSQL_USER: user
    healthcheck:
      interval: 10s
    hostname: db
    image: docksal/mysql:5.7
    logging:
      options:
        max-file: '10'
        max-size: 1m
    ports:
    - published: 0
      target: 3306
    volumes:
    - db_data:/var/lib/mysql:rw
    - project_root:/var/www:ro,nocopy,cached
  web:
    depends_on:
      cli:
        condition: service_started
    dns:
    - 192.168.64.100
    - 8.8.8.8
    environment:
      APACHE_BASIC_AUTH_PASS: null
      APACHE_BASIC_AUTH_USER: null
      APACHE_DOCUMENTROOT: /var/www/docroot
      APACHE_FCGI_HOST_PORT: cli:9000
    healthcheck:
      interval: 10s
    hostname: web
    image: docksal/apache:2.4-2.3
    labels:
      io.docksal.cert-name: none
      io.docksal.permanent: "false"
      io.docksal.project-root: /Users/user/Projects/bltd9
      io.docksal.virtual-host: bltd9.docksal,*.bltd9.docksal,bltd9.docksal.*
    logging:
      options:
        max-file: '10'
        max-size: 1m
    volumes:
    - project_root:/var/www:ro,nocopy,cached
version: '2.1'
volumes:
  cli_home: {}
  db_data: {}
  docksal_ssh_agent:
    external: true
    name: docksal_ssh_agent
  project_root:
    driver: local
    driver_opts:
      device: :/Users/user/Projects/bltd9
      o: addr=192.168.64.1,vers=3,nolock,noacl,nocto,noatime,nodiratime,actimeo=1
      type: nfs

---------------------

Output of fin sysinfo:

fin sysinfo output


███  FIN
fin version: 1.103.0

███  OS
Darwin Mac OS X 10.15.7
Darwin UIT-C02D26LZMD6M 19.6.0 Darwin Kernel Version 19.6.0: Tue Jan 12 22:13:05 PST 2021; root:xnu-6153.141.16~1/RELEASE_X86_64 x86_64

███  ENVIRONMENT
MODE : VirtualBox VM
DOCKER_HOST : tcp://192.168.64.100:2376
DOCKSAL_NFS_PATH : /Users

NFS EXPORTS:

# <ds-nfs docksal
/Users 192.168.64.1 192.168.64.100 -alldirs -maproot=0:0
# ds-nfs>

███  DOCKER
EXPECTED CLIENT VERSION: 19.03.13
EXPECTED SERVER VERSION: 19.03.5

Client: Docker Engine - Community
Version:           19.03.13
API version:       1.40
Go version:        go1.13.15
Git commit:        4484c46d9d
Built:             Wed Sep 16 16:58:31 2020
OS/Arch:           darwin/amd64
Experimental:      false

Server: Docker Engine - Community
Engine:
Version:          19.03.5
API version:      1.40 (minimum version 1.12)
Go version:       go1.12.12
Git commit:       633a0ea838
Built:            Wed Nov 13 07:28:45 2019
OS/Arch:          linux/amd64
Experimental:     false
containerd:
Version:          v1.2.10
GitCommit:        b34a5c8af56e510852c35414db4c1f4fa6172339
runc:
Version:          1.0.0-rc8+dev
GitCommit:        3e425f80a8c931f88e6d94a8c831b9d5aa481657
docker-init:
Version:          0.18.0
GitCommit:        fec3683

███  DOCKER COMPOSE
EXPECTED VERSION: 1.27.4
docker-compose version 1.27.4, build 40524192
docker-py version: 4.3.1
CPython version: 3.7.7
OpenSSL version: OpenSSL 1.1.1g  21 Apr 2020

███  DOCKER MACHINE
EXPECTED VERSION: 0.16.2
docker-machine version 0.16.2, build bd45ab13

NAME      ACTIVE   DRIVER       STATE     URL                         SWARM   DOCKER     ERRORS
docksal   *        virtualbox   Running   tcp://192.168.64.100:2376           v19.03.5

███  DOCKSAL: PROJECTS
project              STATUS                      virtual host                                                                           project root
bltd9                Up 18 minutes (healthy)     bltd9.docksal,*.bltd9.docksal,bltd9.docksal.*                                          /Users/User/Projects/bltd9
d7                   Exited (0) 19 hours ago     d7.docksal,*.d7.docksal,d7.docksal.*                                                   /Users/User/Projects/d7
noblestudy           Exited (0) 5 days ago       noblestudy.docksal,*.noblestudy.docksal,noblestudy.docksal.*                           /Users/User/Projects/noblestudy
ace-gryphon          Exited (0) 42 hours ago     ace-gryphon.docksal,*.ace-gryphon.docksal,ace-gryphon.docksal.*                        /Users/User/Projects/ace-gryphon
ace-orgpro      Exited (0) 2 days ago       ace-orgpro.docksal,*.ace-orgpro.docksal,ace-orgpro.docksal.*            /Users/User/Projects/ace-orgpro
acsf-cardinald7      Exited (0) 31 minutes ago   acsf-cardinald7.docksal,*.acsf-cardinald7.docksal,acsf-cardinald7.docksal.*            /Users/User/Projects/acsf-cardinald7
wp                   Exited (0) 2 weeks ago      wp.docksal,*.wp.docksal,wp.docksal.*                                                   /Users/User/Projects/wp
studylca             Exited (0) 5 days ago       studylca.docksal,*.studylca.docksal,studylca.docksal.*                                 /Users/User/Projects/studylca
d8                   Exited (0) 19 hours ago     d8.docksal,*.d8.docksal,d8.docksal.*                                                   /Users/User/Projects/d8
test-grunt           Exited (0) 2 weeks ago      test-grunt.docksal,*.test-grunt.docksal,test-grunt.docksal.*                           /Users/User/Projects/test-grunt
acsf-lelandd8        Exited (255) 3 days ago     acsf-lelandd8.docksal,*.acsf-lelandd8.docksal,acsf-lelandd8.docksal.*                  /Users/User/Projects/acsf-lelandd8
infounityhdfn        Exited (255) 3 weeks ago    infounityhdfn.docksal,*.infounityhdfn.docksal,infounityhdfn.docksal.*                  /Users/User/Projects/info.unityhdfn
acsf-cardinalsites   Exited (0) 19 hours ago     acsf-cardinalsites.docksal,*.acsf-cardinalsites.docksal,acsf-cardinalsites.docksal.*   /Users/User/Projects/acsf-cardinalsites
sws_soe_ace          Exited (255) 4 weeks ago    sws-soe-ace.docksal,*.sws-soe-ace.docksal,sws-soe-ace.docksal.*                        /Users/User/Dev/sws_soe_ace
cardinalatwork       Exited (0) 9 days ago       cardinalatwork.docksal,*.cardinalatwork.docksal,cardinalatwork.docksal.*               /Users/User/Projects/cardinalatwork
user                 Exited (255) 2 months ago   user.docksal,*.user.docksal,user.docksal.*                                             /Users/User/Projects/user
timer                Exited (0) 4 weeks ago      timer.docksal,*.timer.docksal,timer.docksal.*                                          /Users/User/Projects/timer
wordpress            Exited (0) 2 months ago     wordpress.docksal,*.wordpress.docksal,wordpress.docksal.*                              /Users/User/Projects/wordpress
journald             Exited (0) 2 months ago     journald.docksal,*.journald.docksal,journald.docksal.*                                 /Users/User/Dev/journald
swswpmigration       Exited (0) 2 months ago     swswpmigration.docksal,*.swswpmigration.docksal,swswpmigration.docksal.*               /Users/User/Projects/swswpmigration
blueprint            Exited (0) 3 months ago     blueprint.docksal,*.blueprint.docksal,blueprint.docksal.*                              /Users/User/Projects/blueprint
kidsmigrainestudy    Exited (0) 3 months ago     kidsmigrainestudy.docksal,*.kidsmigrainestudy.docksal,kidsmigrainestudy.docksal.*      /Users/User/Projects/kidsmigrainestudy
lumeostudy           Exited (0) 3 months ago     lumeostudy.docksal,*.lumeostudy.docksal,lumeostudy.docksal.*                           /Users/User/Projects/lumeostudy

███  DOCKSAL: VIRTUAL HOSTS
�[0;32m*.bltd9.docksal�[0m
�[0;32mbltd9.docksal.*�[0m
�[0;32mbltd9.docksal�[0m

███  DOCKSAL: NETWORKING

DOCKSAL_IP: 192.168.64.100
DOCKSAL_HOST_IP: 192.168.64.1
DOCKSAL_VHOST_PROXY_IP:
DOCKSAL_DNS_IP:
DOCKSAL_DNS_DISABLED: 0
DOCKSAL_NO_DNS_RESOLVER: 0
DOCKSAL_DNS_UPSTREAM:
DOCKSAL_DNS_DOMAIN: docksal

███  DOCKSAL: CONNECTIVITY

Host to 192.168.64.100: 	PASS
Container to 192.168.64.100: 	PASS
Container to 192.168.64.1: 	PASS

Checking connectivity to http://dns-test.docksal...
Host: PASS
Containers: PASS

███  DOCKER: RUNNING CONTAINERS
CONTAINER ID        IMAGE                     COMMAND                  CREATED             STATUS                    PORTS                                                    NAMES
285199b485d7        docksal/apache:2.4-2.3    "httpd-foreground"       18 minutes ago      Up 18 minutes (healthy)   80/tcp, 443/tcp                                          bltd9_web_1
31c2c05912de        docksal/cli:2.12-php7.3   "/opt/startup.sh sup…"   18 minutes ago      Up 18 minutes (healthy)   22/tcp, 3000/tcp, 9000/tcp                               bltd9_cli_1
794d73c53623        docksal/mysql:5.7         "docker-entrypoint.s…"   18 minutes ago      Up 18 minutes (healthy)   33060/tcp, 0.0.0.0:32768->3306/tcp                       bltd9_db_1
7a068599d856        docksal/ssh-agent:1.3     "docker-entrypoint.s…"   24 minutes ago      Up 24 minutes (healthy)                                                            docksal-ssh-agent
402edafc609e        docksal/dns:1.1           "docker-entrypoint.s…"   24 minutes ago      Up 24 minutes (healthy)   192.168.64.100:53->53/udp                                docksal-dns
7140398aa41e        docksal/vhost-proxy:1.6   "docker-entrypoint.s…"   24 minutes ago      Up 24 minutes (healthy)   192.168.64.100:80->80/tcp, 192.168.64.100:443->443/tcp   docksal-vhost-proxy

███  DOCKER: NETWORKS
NETWORK ID          NAME                    DRIVER              SCOPE
afec32020ca5        _default                bridge              local
0c0f0505087e        acsf-lelandd8_default   bridge              local
55b6bb34890f        bltd9_default           bridge              local
3341378fb385        bridge                  bridge              local
7755ca0dd4e3        host                    host                local
9b07aa9233d0        infounityhdfn_default   bridge              local
ea60c62827dd        none                    null                local
e0ce90a99799        sws_soe_ace_default     bridge              local
57921ca1ca2b        user_default            bridge              local

███  VIRTUALBOX
EXPECTED VERSION: 6.1.16
6.1.16r140961

███  DOCKSAL MOUNTS
192.168.64.1:/Users on /Users type nfs (rw,noatime,nodiratime,vers=3,rsize=65536,wsize=65536,namlen=255,acregmin=1,acregmax=1,acdirmin=1,acdirmax=1,hard,nocto,nolock,noacl,proto=tcp,timeo=600,retrans=2,sec=sys,mountaddr=192.168.64.1,mountvers=3,mountport=987,mountproto=udp,local_lock=all,addr=192.168.64.1)
192.168.64.1:/Users/User/Projects/bltd9 on /mnt/sda1/var/lib/docker/volumes/bltd9_project_root/_data type nfs (rw,noatime,nodiratime,vers=3,rsize=65536,wsize=65536,namlen=255,acregmin=1,acregmax=1,acdirmin=1,acdirmax=1,hard,nocto,nolock,noacl,proto=tcp,timeo=600,retrans=2,sec=sys,mountaddr=192.168.64.1,mountvers=3,mountport=987,mountproto=udp,local_lock=all,addr=192.168.64.1)

███  HDD Usage
Filesystem                Size      Used Available Use% Mounted on
/dev/sda1                46.1G     36.6G      7.1G  84% /mnt/sda1

Provide "custom" package directories

composer.json specifies that custom packages go in custom directories (i.e. docroot/modules/custom) but those directories don't actually get created until someone adds such a package.

To provide a clearer indication to users about where they should put their first custom package, I think we should provide those (empty) directories out of the box.

This will also prevent blt validate failures.

Remove drupal/mysql Package

The drupal/mysql56 package is no longer required for Drupal 9. This should be removed from https://github.com/acquia/drupal-recommended-project/blob/master/composer.json#L22

Provide .htaccess in config/default

Tried installing this on Acquia Cloud without a local first. Got this issue:

 // Do you want to continue?: yes.

 [notice] Starting Drupal installation. This takes a while.
 [notice] Performed install task: install_select_language
 [notice] Performed install task: install_select_profile
 [notice] Performed install task: install_load_profile
 [notice] Performed install task: install_verify_requirements
 [notice] Performed install task: install_verify_database_ready
 [error]  Security warning: Couldn't write .htaccess file. Please create a .htaccess file in your ../config/default directory which contains the following lines: <pre><code># Deny all requests from Apache 2.4+.
<IfModule mod_authz_core.c>
  Require all denied
</IfModule>

# Deny all requests from Apache 2.0-2.2.
<IfModule !mod_authz_core.c>
  Deny from all
</IfModule>

# Turn off all options we don't need.
Options -Indexes -ExecCGI -Includes -MultiViews

# Set the catch-all handler to prevent scripts from being executed.
SetHandler Drupal_Security_Do_Not_Remove_See_SA_2006_006
<Files *>
  # Override the handler again if we're run later in the evaluation list.
  SetHandler Drupal_Security_Do_Not_Remove_See_SA_2013_003
</Files>

# If we know how to do it safely, disable the PHP engine entirely.
<IfModule mod_php7.c>
  php_flag engine off
</IfModule></code></pre>
 [notice] Performed install task: install_base_system
 [notice] Performed install task: install_bootstrap_full

DX-5165: Getting timeout error while installing headless ACMS using composer script

Error -

Enabling Starter module for the starter-kit:
--------------------------------------------
> './vendor/bin/drush' 'en' '--yes' 'acquia_cms_starter'
 [warning] The Google API key is not set, and you will see errors below. They're technically harmless, but the maps will not work. You can set the key later and resave your starter content to generate them.
The following module(s) will be enabled: acquia_cms_starter, acquia_cms_document, acquia_cms_video, webform

 // Do you want to continue?: yes.

The following exception is caused by a process timeout
Check https://getcomposer.org/doc/06-config.md#process-timeout for details

In Process.php line 1204:

  The process "./vendor/bin/acms acms:install" exceeded the timeout of 300 seconds.

Steps I used -

Used template acquia/drupal-recommended-project for setup
Ran the command - composer acms:install
Selected headless mode with default content and nextJS site setup as well

This seems happening because composer script has default timeout of 300 seconds. For reference https://getcomposer.org/doc/06-config.md#process-timeout

DX-5159: After installing the project i got an error

Add oomphinc / composer-installers-extender

The tool installs composer/installers, but since we use the installer-type key in the composer.json to be able to bring both bower-asset and npm-asset types of packages, the oomphinc/composer-installers-extender is needed for that to work.

Otherwise all bower-assets and npm-assets will be installed in the vendor folder.

This package was previously brought in by acquia/lightning.

DX-5175: Tests failing

Due to ORCA v3.25.0

DX-5156: Instruct users to run acms:install to select install type

I had no idea I needed to run vendor/bin/acms acms:install to get a viable code base.

ACMS-1550: Error applying patch on fresh install

Installing brand new site using:

$ composer create-project acquia/drupal-recommended-project project
$ cd project
$ ./vendor/bin/acms acms:install acquia_cms_headless

Throws patch error

 - Applying patches for drupal/subrequests
    https://www.drupal.org/files/issues/2019-07-18/change_request_type-63049395-09.patch (Get same results on different request)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2019-07-18/change_request_type-63049395-09.patch

In PluginManager.php(285) : eval()'d code line 326:

  Cannot apply patch Get same results on different request (https://www.drupal.org/files/issues/2019-07-18/change_request_type-63049395-09.patch)!

DX-5137: Automate ./vendor/bin/acms acms:install to run on composer create-project

When this template is instantiated, it should continue to run ./vendor/bin/acms acms:install to proceed to the next step of choosing the Acquia CMS 2.0 starter kit automatically rather than the end user having to initiate it manually.

Do not prompt when installing plugins with Composer 2.2.x

With Composer 2.2.x we have more secure plugin execution. As such, Composer is going to ask user input before pulling plugins. For Acquia's Drupal recommended project, the user is prompted 5-6 times, which is annoying and confusing.

See https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution

Add scaffolding and remove gitignore for settings.php

For whatever reason, we are gitignoring the docroot/sites/default/settings.php file. I believe this shouldn't be the case (and I always have to force add it).

Also, for those using this scaffolding w/o BLT, there isn't currently anything that will automatically generate a settings.php file. We should probably add a composer script to copy default.settings.php to settings.php.

Gitignore file not properly formatted for Drupal development projects

The gitignore project that ships with drupal-recommended-project makes sense for this repo, but it doesn't make sense for a Drupal project. Specifically:

it has composer.lock gitignored (bad)
it is missing all of the local file system ignores (e.g. .DS_Store)
it duplicates entires for .editorconfig and .gitattributes (which I don't think should be gitignored anyway)

While I can put in a new PR to fix this as discussed @danepowell I think we have a larger problem here (because obviously you want composer.lock git ignored for this project but we don't want to force folks to gitignore this in their builds). So I think we need to tweak something here to get that lined up.

ACMS-1651: The github release drafter creating empty releases.

The Github release drafter has created empty releases. Ex:

Acquia CMS is not installed instead lightning installed

Hi,

I have created new project by running below command
composer create-project --no-interaction acquia/drupal-recommended-project

It is not installing the acquia cms but it is installing acquia lightning. Do I need to do anything?

Thanks
Iyyappan

ACMS-1838: Need to enable PHP 8.2 testing

I have created the following PRs -

#389 for 1.x branch.
#390 for master branch.

Please review and merge them. Let me know if you have queries.