Code Monkey home page Code Monkey logo

Comments (12)

davkovacs avatar davkovacs commented on August 28, 2024 1

You are completely right. This should be much better handled.

from mace.

ilyes319 avatar ilyes319 commented on August 28, 2024

We definitly should add an assert including other extensions. What other extensions can it support?

from mace.

bernstei avatar bernstei commented on August 28, 2024

Tens of them, but not all support quantities such as energies/forces/etc. And anyway, why an assert? Why not let it raise an exception if it can't handle it?

from mace.

bernstei avatar bernstei commented on August 28, 2024

https://wiki.fysik.dtu.dk/ase/ase/io/io.html

from mace.

ilyes319 avatar ilyes319 commented on August 28, 2024

I am fine with removing the asserts. @davkovacs What do you think?

from mace.

davkovacs avatar davkovacs commented on August 28, 2024

I can fix this.

from mace.

davkovacs avatar davkovacs commented on August 28, 2024

d569918

from mace.

davkovacs avatar davkovacs commented on August 28, 2024

I will close this when you say the fix is okay.

from mace.

bernstei avatar bernstei commented on August 28, 2024

I put in some comments on the commit, but there's no corresponding PR yet.

from mace.

davkovacs avatar davkovacs commented on August 28, 2024

Can I close this issue?

from mace.

bernstei avatar bernstei commented on August 28, 2024

Fine by me, yes.

from mace.

ilyes319 avatar ilyes319 commented on August 28, 2024

Closing, looks fine.

from mace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.