Code Monkey home page Code Monkey logo

Comments (7)

davkovacs avatar davkovacs commented on August 28, 2024

Hi! Sorry, I am not sure I understand what you changed?
could you perhaps explain a little more?

from mace.

mahpe avatar mahpe commented on August 28, 2024

Actually I think there might be a mistake in the function I wrote.
It works fine for training, but in the MD prediction it gives an error.

The hole idea of my implementation was to be able to use ASE trajectory files :) Do you think that can be made possible?

from mace.

ilyes319 avatar ilyes319 commented on August 28, 2024

Could you post the error you get when trying to load your traj file? If ase.io.read works the same way on them, I am not sure where the problem might be.

from mace.

mahpe avatar mahpe commented on August 28, 2024

The energy and forces will not be loaded, since they do not have the atoms.info and atoms.arrays dictionary :) The will not be an error by it self but the model is not training.

from mace.

ilyes319 avatar ilyes319 commented on August 28, 2024

The problem with the command extraction is that it can be unreliable. If a calculator is attached to the atom object, it can give inconsistent results. For this reason, storing your data in the info with a custom key is highly recommended. In particular, .traj files are usually associated with the calculator that generated them. Is there an easy way to convert the .traj to .xyz? We could add this pre-processing.

from mace.

bernstei avatar bernstei commented on August 28, 2024

I think traj files store those quantities in a SinglePointCalculator, which is an essentially static storage that fills in the return values for get_potential_energy() etc. In fact, it's probably safer than quantities from extxyz, because I think the calculator is invalidated if you modify positions etc. It's just not possible to do things like save multiple sets of results from different calculators. It would, of course, be trivial to write a little loop that reads the calculator and stores the results in info/arrays. The ase.io extxyz reader probably already does that, I think.

from mace.

mahpe avatar mahpe commented on August 28, 2024

I think converting traj to xyz file will require mor space since you will have the same data file twice.
What Bernstei suggest would be a great solution!

from mace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.