Code Monkey home page Code Monkey logo

Comments (17)

YuriSizov avatar YuriSizov commented on June 15, 2024

I second that as current version generates small yet annoying warning about cloneWithProps deprecation in FluxComponent. It would be great if before 4.0 is released we had a clean non-breaking version compatible with the latest React.

from flummox.

voronianski avatar voronianski commented on June 15, 2024

@pycbouh @okonet I'm planning to add React 0.14.x support however I'm still thinking of how is it better to do this. NPM already contains Flummox 4.x rc version which makes it problematic to add latest React support to stable 3.x version. Your thoughts?

from flummox.

okonet avatar okonet commented on June 15, 2024

Since this package does not follow semver ATM, I think it should be released as 3.x release + information about it should be added to README. What do you think?

from flummox.

voronianski avatar voronianski commented on June 15, 2024

@okonet current master branch contains breaking changes of Flummox 4.x alpha version, do you propose to revert back master to the state of latest stable 3.x release, add React support here and republish it to npm as 3.x release?

from flummox.

okonet avatar okonet commented on June 15, 2024

Yes, since 0.4 was never released, React 0.14 support for it doesn't bring a lot for current users of flummox.

I'd propose not to revert but create a branch from a latest released tag and apply changes there and then release as a 0.3.x release

from flummox.

okonet avatar okonet commented on June 15, 2024

Or even create a 1.x release finally and use SemVer from there

from flummox.

voronianski avatar voronianski commented on June 15, 2024

@okonet I think there are still some users that use alpha release of 4.x..

Or even create a 1.x release finally and use SemVer from there

it's not possible :) 'cause 1.0 was already released, we can upgrade to 5.0 though it will be the same as 3.x with React support.. sounds a bit strange :)

from flummox.

okonet avatar okonet commented on June 15, 2024

Oh true, I was thinking it's still in 0.x range. Well, it seems even SemVer doesn't help to resolve such situations, or am I missing something?

from flummox.

YuriSizov avatar YuriSizov commented on June 15, 2024

@voronianski We can have a separate 3.x branch in NPM, with 4.x being stable, can't we?

from flummox.

voronianski avatar voronianski commented on June 15, 2024

@pycbouh I'm not sure, need to investigate this.

from flummox.

voronianski avatar voronianski commented on June 15, 2024

@pycbouh it looks like it's possible with npm publish --tag (https://docs.npmjs.com/cli/publish), correct me if I wrong.

from flummox.

voronianski avatar voronianski commented on June 15, 2024

@okonet @pycbouh so then plan is to add React 0.14 support into 3.x version and release new stable patch as 3.6.0, I plan to do this during weekend.

from flummox.

YuriSizov avatar YuriSizov commented on June 15, 2024

@voronianski I believe you are correct with npm publish --tag. Actually, npm dist-tag ls flummox (https://docs.npmjs.com/cli/dist-tag) shows, that 4.0 rc is using another tag already.

latest: 3.5.2
prerelease: 4.0.0-rc1

Anyway, thank you!

from flummox.

voronianski avatar voronianski commented on June 15, 2024

@okonet @pycbouh added in 3.6.x version.

from flummox.

Pavek avatar Pavek commented on June 15, 2024

@voronianski Please list this version in Releases too. That's how many people, including me, discover new stuff. Thanks.

from flummox.

voronianski avatar voronianski commented on June 15, 2024

@Pavek added, thanks

from flummox.

okonet avatar okonet commented on June 15, 2024

Cool! Thanks!

from flummox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.