Code Monkey home page Code Monkey logo

Comments (2)

pqarmitage avatar pqarmitage commented on August 16, 2024 1

@Bbulatov Many thanks for reporting this. I think, however, that the problem is worse than you identify, meaning that currently whatever value of the timer is used is irrelevant.

The code at lines 895-897, currently:

                                if (tpr->fork_delay)
                                        tpr->fork_timer_thread = thread_add_timer(master, process_gained_quorum_timer_thread, tpr, tpr->terminate_delay);
                                process_update_track_process_status(tpr, true);

I think should be:

                                if (tpr->fork_delay)
                                        tpr->fork_timer_thread = thread_add_timer(master, process_gained_quorum_timer_thread, tpr, tpr->fork_delay);
                                else
                                        process_update_track_process_status(tpr, true);

In other words, not only is the delay timer the wrong one, as you identified, but process_update_track_process_status() should not be called if there is a fork_delay configured.

I need to think this through carefully and do some testing before producing a patch.

from keepalived.

pqarmitage avatar pqarmitage commented on August 16, 2024 1

Commit 3df2947 resolves this issue, and a couple of others I identified while investigating it.

from keepalived.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.