Code Monkey home page Code Monkey logo

Comments (9)

GoogleCodeExporter avatar GoogleCodeExporter commented on May 22, 2024
Fantastic stuff - thanks, Jacob.

Added in revision 28.

Keeping this open until I add the docs for it.

Original comment by jonathan.buchanan on 11 Mar 2007 at 5:52

  • Changed state: Started
  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect

from django-tagging.

GoogleCodeExporter avatar GoogleCodeExporter commented on May 22, 2024
Currently, this will blow up when you try to assign tags when initially 
creating an
object, as it hasn't been saved yet when __set__ is called.

Is this something that can be worked around?

Original comment by jonathan.buchanan on 11 Mar 2007 at 11:50

  • Added labels: ****
  • Removed labels: ****

from django-tagging.

GoogleCodeExporter avatar GoogleCodeExporter commented on May 22, 2024
Ah, that's because the object doesn't have a primary key yet. Let me explore 
how I
might defer setting tags until later...

Original comment by [email protected] on 12 Mar 2007 at 3:29

  • Added labels: ****
  • Removed labels: ****

from django-tagging.

GoogleCodeExporter avatar GoogleCodeExporter commented on May 22, 2024
OK, attached is a first stab at making tag assignment to unsaved items work. 
It's a
pretty nasty hack, though, so we should spend a bit of time looking for better 
options.

Original comment by [email protected] on 12 Mar 2007 at 4:25

  • Added labels: ****
  • Removed labels: ****

Attachments:

from django-tagging.

GoogleCodeExporter avatar GoogleCodeExporter commented on May 22, 2024
That last nasty patch had a bug in it; attached is a fix.

It's still nasty, though.

Original comment by [email protected] on 12 Mar 2007 at 2:58

  • Added labels: ****
  • Removed labels: ****

Attachments:

from django-tagging.

GoogleCodeExporter avatar GoogleCodeExporter commented on May 22, 2024
Applied the patch in revision 33 - I applied the goggles while checking the 
patch in,
but they did nothing :)

Original comment by jonathan.buchanan on 12 Mar 2007 at 10:57

  • Added labels: ****
  • Removed labels: ****

from django-tagging.

GoogleCodeExporter avatar GoogleCodeExporter commented on May 22, 2024
This seems to throw an AttributeError when trying to delete a tagging instance. 
It seems to be calling an 
attribute '__tags_save_defered_tags' which no longer (or never did) exist.

Original comment by jeffwheeler on 16 Mar 2007 at 10:03

  • Added labels: ****
  • Removed labels: ****

from django-tagging.

GoogleCodeExporter avatar GoogleCodeExporter commented on May 22, 2024
After looking at `delete_objects` in django.db.models.query, I've modified 
`TagField`
in revision 36 to delete tags when the `pre_delete` signal is dispatched.

The `delete_objects` function sets the primary key attribute to `None` before
dispatching the `post_delete` signal, but we need the primary key to be on the
instance when making the call to `TagManager.update_tags`.

Original comment by jonathan.buchanan on 17 Mar 2007 at 11:13

  • Added labels: ****
  • Removed labels: ****

from django-tagging.

GoogleCodeExporter avatar GoogleCodeExporter commented on May 22, 2024
Patched again in issue 13.

Original comment by jonathan.buchanan on 11 May 2007 at 2:15

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

from django-tagging.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.