When liquidating an unsafe loan, collateral_balance is 0, and no additional auction ev

Liquidate not triggering auction about acala HOT 1 CLOSED

acalanetwork commented on July 22, 2024

Liquidate not triggering auction

from acala.

Comments (1)

wangjj9219 commented on July 22, 2024

This fault is actually caused by lacking of check for zero debit_balance when try to liquidate a cdp with 0 collateral and 0 debit ：

Acala/modules/cdp_engine/src/lib.rs

Lines 288 to 301 in 21f35d4

    
           let debit_balance = <loans::Module<T>>::debits(&who, currency_id); 
        
           let collateral_balance = <loans::Module<T>>::collaterals(&who, currency_id); 
        
           let stable_currency_id = T::GetStableCurrencyId::get(); 
        
           // first: ensure the cdp is unsafe 
        
           let feed_price = 
        
           	T::PriceSource::get_price(stable_currency_id, currency_id).ok_or(Error::<T>::InvalidFeedPrice)?; 
        
           let collateral_ratio = 
        
           	Self::calculate_collateral_ratio(currency_id, collateral_balance, debit_balance, feed_price); 
        
           let liquidation_ratio = Self::get_liquidation_ratio(currency_id); 
        
           ensure!( 
        
           	collateral_ratio < liquidation_ratio, 
        
           	Error::<T>::CollateralRatioStillSafe 
        
           );

The bug will be fixed soon.

from acala.

Liquidate not triggering auction about acala HOT 1 CLOSED

Comments (1)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	let debit_balance = <loans::Module<T>>::debits(&who, currency_id);
	let collateral_balance = <loans::Module<T>>::collaterals(&who, currency_id);
	let stable_currency_id = T::GetStableCurrencyId::get();

	// first: ensure the cdp is unsafe
	let feed_price =
	T::PriceSource::get_price(stable_currency_id, currency_id).ok_or(Error::<T>::InvalidFeedPrice)?;
	let collateral_ratio =
	Self::calculate_collateral_ratio(currency_id, collateral_balance, debit_balance, feed_price);
	let liquidation_ratio = Self::get_liquidation_ratio(currency_id);
	ensure!(
	collateral_ratio < liquidation_ratio,
	Error::<T>::CollateralRatioStillSafe
	);