Code Monkey home page Code Monkey logo

Comments (2)

dborovcanin avatar dborovcanin commented on June 5, 2024

This looks like we need to Unwrap and replace the whole error with the wrapper in the API layer.

from magistrala.

WashingtonKK avatar WashingtonKK commented on June 5, 2024

@dborovcanin, unwrapping is a good idea but it will not always work because some errors are not wrapped, and since we will replace the entire error with the wrapper; we might get a nil error while there actually was an error.

Here is an example where and Authorization error is sent but it is not wrapped.

https://github.com/absmach/magistrala/blob/f733147517bb29d5f2a3815b3022462e7234bd1c/users/service.go#L643C1-L645C3

I think @arvindh123 's proposal is fine, if the a service error is contained in an error we replace the entire error with the service error. Then the other errors will be found as logs.

from magistrala.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.