Code Monkey home page Code Monkey logo

Comments (4)

kyasu1 avatar kyasu1 commented on August 25, 2024

Hi thank you for the great libs :-)

After this modification, the has_next_page never become true, because length(records) is always less than or equal to limit, as the query indicates. To solve the both problems, probably we need to naively count the total records and compare it with (offset + limit) as done in from_list.

from absinthe_relay.

bruce avatar bruce commented on August 25, 2024

@kyasu1 ugh, yes. We'll take a look at this tomorrow morning. Thanks for pointing this out.

from absinthe_relay.

benwilson512 avatar benwilson512 commented on August 25, 2024

The downside with doing a count is that we have now to do 2 db queries. My inclination here is to grab limit + 1 records out of the DB, then use length(records) > limit, but then only return Enum.take(rows, limit).

Thoughts?

from absinthe_relay.

kyasu1 avatar kyasu1 commented on August 25, 2024

@benwilson512 Yea agree with you, less query is always better. I tried your solution in my project and it solved the problem, it is neat. Please take a look at the pull request.

from absinthe_relay.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.