Code Monkey home page Code Monkey logo

Comments (5)

derekmauro avatar derekmauro commented on June 2, 2024

Does the patch proposed in #1624 (comment) fix the problem? That would be a hint that this is actually the same issue as #1624.

from abseil-cpp.

h-vetinari avatar h-vetinari commented on June 2, 2024

Does the patch proposed in #1624 (comment) fix the problem? That would be a hint that this is actually the same issue as #1624.

We ran into this problem with the patched abseil. There are three possibilities as far as I can see:

  • the patch is independent of the bug
  • the patch uncovered the bug
  • the patch introduced the bug

I still think that it's very closely related, because of the way how constructors/destructors are (apparently) missing in the shared library.

However, it is not the same in the sense that the tensorflow builds do set NDEBUG.

from abseil-cpp.

h-vetinari avatar h-vetinari commented on June 2, 2024

@derekmauro, what do you think about the situation here now? I get that you'd like constructurs/destructors to be inlined as much as possible, but given that synchronization_internal::KernelTimeout is used from another library (absl_mutex), this doesn't work in shared builds.

from abseil-cpp.

derekmauro avatar derekmauro commented on June 2, 2024

I haven't had time to look into this, sorry.

from abseil-cpp.

h-vetinari avatar h-vetinari commented on June 2, 2024

Yeah, it's OK. I managed to dig a bit more and found it's an interaction between bazel/tensorflow and their vendored abseil. I'll close this, as there's nothing to do for abseil AFAICT.

from abseil-cpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.