Comments (3)
On a slightly pedantic note, an InlinedVector of objects in maybe-moved-from states is still in a valid state, so this technically satisfies basic exception safety -- but I agree it's not a nice thing to do.
I think this is a two step solution -- we declare that InlinedVector only supports T with nothrow move operators in the short term.
In the long term, Abseil's stance on throwing moves constructors is essentially that move constructors can only throw if the allocator can throw -- we're stricter than the standard on thsi point of view. So as I ramp up the exception-safety test suite we can advise the move constructor to be noexcept if the allocator is noexcept and use the current algorithm, and fall back to copying only if the allocator throws and T has a throwing move constructor.
Does this sound reasonable?
from abseil-cpp.
User reported test case at http://codepad.org/YbVsjMy5 but it seems to be inaccessible now.
from abseil-cpp.
Closing as a duplicate of #37
from abseil-cpp.
Related Issues (20)
- [Bug]: clang-analyzer-optin.core.EnumCastOutOfRange for static_cast<ctrl_t>(0) HOT 2
- [Bug]: undefined reference to `absl::lts_20240116::raw_log_internal::internal_log_function[abi:cxx11]' HOT 1
- [Bug]: algorithm\container.h is missing random header and causing compilation error when building protobuf in VS2022 HOT 1
- [Bug]: ASAN use-after-poison in TimeZoneInfo HOT 8
- [Bug]: SEGV with btree_set::equal_range HOT 2
- [Bug]: build failure on redhat/ubi8 HOT 2
- [Bug]: Compilation error for filesystem HOT 1
- [Bug]: raw hash set test crash on centos7 HOT 1
- [Bug]: NegativeNaN test fails on riscv64 HOT 2
- [Bug]: Rounding absl::Time is hacky HOT 4
- [Bug]: btree_multiset memory leak with ASAN enabled HOT 6
- [Bug]: Uninitialized value in AnyInvocable.
- [Bug]: Build failure MSVC x86 with /arch:AVX2 HOT 4
- [Bug]: ABSL_ATTRIBUTE_NORETURN doesn't work in all contexts HOT 1
- [Bug]: Compilation issue on Windows 2022 with Ninja and CMake
- [Bug]: Can't link using riscv64 toolchain
- use vcpkg install absl dll lib link error HOT 1
- [Bug]: Sanitizer options may disagree between library and user leading to ODR violations
- Can't link to MSVC built abseil with clang/LLVM
- improvement : keep cmakelists clean, remove unneeded policy activations that are already active HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abseil-cpp.