Comments (3)
On a slightly pedantic note, an InlinedVector of objects in maybe-moved-from states is still in a valid state, so this technically satisfies basic exception safety -- but I agree it's not a nice thing to do.
I think this is a two step solution -- we declare that InlinedVector only supports T with nothrow move operators in the short term.
In the long term, Abseil's stance on throwing moves constructors is essentially that move constructors can only throw if the allocator can throw -- we're stricter than the standard on thsi point of view. So as I ramp up the exception-safety test suite we can advise the move constructor to be noexcept if the allocator is noexcept and use the current algorithm, and fall back to copying only if the allocator throws and T has a throwing move constructor.
Does this sound reasonable?
from abseil-cpp.
User reported test case at http://codepad.org/YbVsjMy5 but it seems to be inaccessible now.
from abseil-cpp.
Closing as a duplicate of #37
from abseil-cpp.
Related Issues (20)
- [Bug]: Build failure on Mac OS 14.0 HOT 2
- [Bug]: Riscv build of Protobuf fails due to abseil HOT 2
- Build Error on OpenBSD: cannot static_cast<pid_t>(pthread_self()) HOT 2
- undefined reference to `absl::lts_20230802::log_internal::LogMessageFatal::~LogMessageFatal()' HOT 1
- VolatilePtrLogFormatTest fails under C++23 HOT 1
- Absl containers don't have a free swap method HOT 2
- can't swap absl::FixedArray HOT 2
- [Bug]: Compilation failure due to missing bazel platforms support HOT 9
- error: no type named 'string_view' in namespace 'absl' HOT 2
- [Bug]: Publish VLOG HOT 1
- [Bug]: absl::StrFormat doesn't produce correct output under mipsel platform HOT 8
- [Bug]: hash_maps and hash_sets invoke undefined behavior on allocator exceptions.
- installation instructions for users?
- [Bug]: Missing reference to `absl::lts_20211102::strings_internal::AppendPieces
- [Bug]: Build fails: error: use of undeclared identifier 'FP_NAN' HOT 2
- [Bug]: failed to build python-grpcio when using -std=c++14
- [Bug]: UBSAN failure in raw_hash_set.h HOT 10
- [Bug]: cmake installation does not set RPATH/RUNPATH
- [Bug]: My application's clang-tidy build failing from abseil package. HOT 1
- [Bug]: C++17 support broken by https://github.com/abseil/abseil-cpp/commit/f845e60acd880dbf07788a5a2c0dbad0f9c57231 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abseil-cpp.