Reasoning is in the freetype_init() function comment in VisualResources.h

Tried: commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="

Move freetype_init from VisualResources to Visual about morphologica HOT 3 CLOSED

optseb commented on June 10, 2024

Move freetype_init from VisualResources to Visual

from morphologica.

Comments (3)

sebjameswml commented on June 10, 2024

Part of this work is to ALSO move the holding of VisualFaces to each Visual instance.

from morphologica.

sebjameswml commented on June 10, 2024

Tried: commit 9962ff2
Ran into:

[ 14%] Building CXX object tests/CMakeFiles/testhexgrid3.dir/testhexgrid3.cpp.o
In file included from /home/seb/models/morphologica/morph/VisualModel.h:27,
                 from /home/seb/models/morphologica/morph/Visual.h:44,
                 from /home/seb/models/morphologica/tests/testhexgrid3.cpp:8:
/home/seb/models/morphologica/morph/VisualTextModel.h: In constructor ‘morph::VisualTextModel::VisualTextModel(morph::Visual*, GLuint, morph::VisualFont, float, int, morph::vec<float, 3>, const string&, std::array<float, 3>)’:
/home/seb/models/morphologica/morph/VisualTextModel.h:141:41: error: invalid use of incomplete type ‘class morph::Visual’
  141 |             this->face = this->parentVis->getVisualFace (visualfont, this->fontpixels);
      |                                         ^~
compilation terminated due to -Wfatal-errors.
make[2]: *** [tests/CMakeFiles/testhexgrid3.dir/build.make:76: tests/CMakeFiles/testhexgrid3.dir/testhexgrid3.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1296: tests/CMakeFiles/testhexgrid3.dir/all] Error 2
make: *** [Makefile:146: all] Error 2

To fix, I think I'd need to do the bindmodel thing with VisualTextModels. Might make this a 'won't fix' as it works fine as is.

from morphologica.

sebjameswml commented on June 10, 2024

Won't fix - not worth the effort, turns out that holding freetype and fonts in a VisualResources singleton is fine.

from morphologica.

Recommend Projects