Speed up `--store` support about validate-pyproject HOT 11 CLOSED

Yes, the main idea I've been working on is providing a regularly updated copy of the schema store files as a plugin. The problem with releasing this has been #134, since some schema (cibuildwheel, specifically) required fragment support. That's actually not true anymore, since cibuildwheel now uses a partial, so no current files require fragments. This solves caching as well as stability - a regularly updated Python package can be pinned as well.

The --store option could be done in parallel, too. I'd normally do this with async, and that is required for WebAssembly support, but we still support Python 3.6, so that's out.

from validate-pyproject.

@abravalheri, I have pushed https://github.com/henryiii/validate-pyproject-schema-store if you'd like to take a look.

from validate-pyproject.

Very nice @henryiii , thank you!

I wonder if it would make sense to add this in the all extras dependency of validate-pyproject itself (or another extra), or if that would cause cycles...

from validate-pyproject.

I'm not sure about "all". A [schema-store] extra could be nice. We could be careful to avoid cycles, I think (validate-pyproject-schema-store only depends on validate-pyproject via an extra, too).

Where would you like validate-pyproject-schema-store to live, by the way? I have it in henryiii for now, but would be happy to move it now or eventually. If you'd like them both to live together here, for example, that would be fine.

from validate-pyproject.

FYI, I've released validate-pyproject-schema-store, but it doesn't work currently, since the released version of validate-pyproject (0.15) doesn't support uint (Ruff).

from validate-pyproject.

Hi @henryiii, is it just a matter of cutting a new release?
We should be in a good shape for that. I will proceed and do that now.

from validate-pyproject.

Awesome, thanks! It's working. See https://scientific-python.github.io/repo-review/ for an initial demo.

from validate-pyproject.

Will see how the auto-update works after SchemaStore/schemastore#3548.

from validate-pyproject.

Auto update works, merged and released it from my phone. New tool in this update, too, tool.pyright. :)

[schema-store] would make sense, not sure about all, as validate-pyproject-schema-store[all] requests validate-pyproject[all], not sure how that is handled when circular.

from validate-pyproject.

This already caught a mistake in cookie's template: scientific-python/cookie#364 (comment) Nice!

from validate-pyproject.

Thanks @henryiii for the work on validate-pyproject-schema-store. With that we're down to around 1.5 seconds to validate our pyproject.toml file with pre-commit. Which isn't extremely fast, but fast enough for our use case. With that in mind, I'm happy to close this issue as resolved.

from validate-pyproject.