Infinity Progress - was (Unrecognized selector) about react-native-af-video-player HOT 9 CLOSED

Hi @guilharj,

Thanks for the PR. I agree. I think that's the best approach for now. I haven't really tested this with live streaming, so if it's all working as expected that's awesome :)

I'll close this as soon as it's merged.

from react-native-af-video-player.

@guilharj Added your fix in 0.1.4 👍

from react-native-af-video-player.

I think that I've figured out how where is the problem. And appears to be the react-native-slider library. After a deep deep deep debuging of the UIManager.

the Slider.js file has a definition like this:
<Animated.View onLayout={this._measureThumb} renderToHardwareTextureAndroid={true} style={[ {backgroundColor: thumbTintColor}, mainStyles.thumb, thumbStyle, { transform: [ { translateX: thumbLeft }, { translateY: 0 } ], ...valueVisibleStyle } ]} > {this._renderThumbImage()} </Animated.View>

The problem is in the transform style. The Xcode debug console said "Error setting property 'transform' of RCTView with tag #360: Exception thrown while executing UI block: -[NSNull floatValue]: unrecognized selector sent to instance 0x107793ef0"

if I remove this transformation, the code works fine. If anyone with more knowledge of this lib knows the reason, will help a lot. I will still work on this.

from react-native-af-video-player.

UPDATE. I think that the slider needs parameters like minimum and maximum value to the slider. BUT, I'm using a live streaming and this could be tricky.

var thumbLeft = value.interpolate({
inputRange: [minimumValue, maximumValue],
outputRange: [0, containerSize.width - thumbSize.width],
//extrapolate: 'clamp',
});

A Idea to solve this, is deal with live streams at the video control in a different way of common video. What about not using the slider on live streams?

from react-native-af-video-player.

So, bc the livestream, the progress ins Infinity. So what about this idea?

<View style={styles.container}>
      { Platform.OS === 'ios' ?
        <Slider
          onValueChange={val => props.onSeek(val)}
          onSlidingComplete={val => props.onSeekRelease(val)}
          value={progress === Number.POSITIVE_INFINITY ? 0: progress}
          thumbTintColor={theme}
          thumbStyle={thumbStyle}
          trackStyle={trackStyle}
          minimumTrackTintColor={theme}
          maximumTrackTintColor={trackColor}
        />

Note this change
value={progress === Number.POSITIVE_INFINITY ? 0: progress}

from react-native-af-video-player.

@abbasfreestyle What you think?

from react-native-af-video-player.

guilharj@e0ed9b8

Feel free to merge. BYe BYe

from react-native-af-video-player.

Another Way, is not showing the slider, and show a label like "Live Broardcast" The Macos player used on safari do something like this :)

from react-native-af-video-player.

Sounds like a good idea. I may consider this for the future. For now the original solution is good enough :)

from react-native-af-video-player.