Comments (3)
Hey Al, thanks for your note. I capture from my inverter daily, and recent captures look fine (the IP address is reported correctly). My firmware version is 2.3.1.4 (or 2.3.1.R on the inverter web page); what firmware version are you seeing from your inverter? If I'm out of date I'm inclined to update it, and then a pull request would be great.
I'm assuming you saw the issue, then debugged it down to the changed IP address code. How did the bug present itself? Just a blank IP field in the report file, or something more unpleasant?
from sunnyboy-capture.
Ok I'm on totally different firmware (1.3.17.R) so that's likely the issue. Either a different inverter (Sunny boy 5.0, SB5.0-1AV-40 843) or might be a regional thing too. I'm in Australia.
The issue was a blank field, yeah, and so I went digging. Prior to finding your library I'd started reverse engineering the AngularJS app that runs from the inverter's webserver, so wasn't surprised to find a different key.
In any case, it's not a big deal - tbh I wrote the issue before realising it was the only different key in your library, expecting to find a number of them.
from sunnyboy-capture.
Ah, my inverter is a Sunny Boy 3.0 (SB3.0-1SP-US-40 816), in the US.
Hm, since it's just the one key - at least so far - I'm inclined to fix it with a simple hack: check both keys, and let either one set the "ip address" value:
} else if (key2 === "6180_104A9A00") {
transformedDevInfo["ip address"] = deeply_buried_value;
} else if (key2 === "6180_104AB700") {
transformedDevInfo["ip address"] = deeply_buried_value;
}
This way you don't have to maintain a separate fork just for the other key, and I get the benefit of your testing on a different inverter. What do you think?
from sunnyboy-capture.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sunnyboy-capture.