[mate] not notifcates about octopi HOT 4 CLOSED

Do you have "notify-send" installed in your system?

from octopi.

yup it's installed

On 02/05/2014 04:21 PM, Alexandre Arnt wrote:

Do you have "notify-send" installed in your system?

---

Reply to this email directly or view it on GitHub:
#17 (comment)

Klearchos-Angelos Gkountras
--------Contact info-----------
mail [email protected]
xmpp [email protected]
irc jemadux @ frenode

web jemadux.info

Gnu/Linux is not user-friendly.
It is user-friendly.
It is not ignorant-friendly and idiot-friendly.

from octopi.

I have examined octopi-notifier code, MainWindow::sendNotification in particular, and have several remarks:

1. QProcess::startDetached is static public function, it does not require QProcess object. I suspect that

QProcess *send = new QProcess();

causes a memory leak.
2. I do not think that checking desktop environment and if the executable exists are necessary. Running unexisting command will just result in

    bash: <command>: command not found

in stdout and process will quit. The line

    if (WMHelper::isXFCERunning() || WMHelper::isLXDERunning() || WMHelper::isOPENBOXRunning())

must be causing this Mate issue.
I would rewrite this function as follows:

void MainWindow::sendNotification(const QString &msg)
{
      const QString processToExec =
          "notify-send -i /usr/share/icons/octopi_red.png -t 30000 \"" +
           StrConstants::getApplicationName() + "\"  \"" + msg + '"';
      QProcess::startDetached(processToExec);
}

I have not tested this, so sorry if it won't work as expected.

from octopi.

Indeed guys!
Thank you very much for finding and fixing this issue!

from octopi.