[BUG] Layout Size measurement about expandablelayout HOT 4 CLOSED

If you want to use the proposed fix, I would be happy to provide a PR.

from expandablelayout.

@Desdroid

Thank you for a polite reporting. 👍

I know this method which is getMeasuredHeight() and getMeasuredWidth().
But these don't work as I expect to.

• your question

Or is there any reason why you have to calculate it on your own ?

I want to create ExpandableRelativeLayout.move() and ExpandableRelativeLayout.moveChild().
So, I calculate the height and width in onMeasure().

And my library seems to work.
I pushed the test branch.
Is this correct code implemented your explaining?
Please check it if my code is wrong.
https://github.com/AAkira/ExpandableLayout/compare/feature/test?expand=1

from expandablelayout.

@AAkira
You're welcome, nothing is more annoying than a bad bug report.
Ahh, now i see why they are necessary.

Acutally I think now that my "Bug" might be some misunderstanding in the usage of the libary.
As reported (I used some wrong Markdown now it's visible) I was putting inside your Layout 3 Child views, which were aligned next to each other. (android:layout_toRightOf="@id/someId")
The orientation of the ExpandableRelativeLayout was vertical.

In your logic those 3 elements were 3 different children and since orientation was vertical you wanted to provide me the ability to move them (upwards or downwards).
Therefore you calculated the layout as if they were all beneath each other and when I did expand it, it had a height, which was too high.

For me though, these 3 childs were logically 1 Child (1 row). I didn't want them to move. I guess for my use case you really have to put those 3 children into 1 Layout.

Nevertheless I'm gonna show you my use case in the test branch, I currently don't have that much time, hope I'll be able to do it tomorrow.

Some possible options which come to my mind:

• Check in your calculation also the alignment and take it into account (along with the height calculated by the RelativeLayout)
  or :
• Make in your Readme the concept more clear (Everything which is for the user one logic row has to be put inside a layout)

from expandablelayout.

I opened a PR, you can have a look at it.

Here are some screenshots to the issue.
This is the layout colaapsed, the pink view is some other content beneath.

This is the layout expanded, as you can see the white space is wrong here.
It has exactly the size of the blue text view.

And finally here is the Log to the "wrong" height calculation.

As already stated I think it's not really a "bug" but rather a case where you have to take special steps (Wrap the views for a logic row in one layout --> Then it will be 1 child for your layout as well)

from expandablelayout.