Code Monkey home page Code Monkey logo

Comments (3)

joerdav avatar joerdav commented on July 23, 2024

I think it would be standard form for that to be an extra function that ends with f such as URLf. I believe that this standard is used by editors to highlight the format string differently.

from templ.

a-h avatar a-h commented on July 23, 2024

I like the idea of having a url format / builder function.

If it was the signature of Sprintf, e.g.: urlf.Sprintf("/path/%s/fileName.js?%s=%v", "pathvar/", "qkey?", "&other=true") there's a few dangers to consider... Because of the context of the variable substitution, there's a risk of injection attacks, so the values would need to be appropriately escaped:

  • path variables need to be path escaped so that / etc. is encoded.
  • query variables need to be query escaped so that ?, = etc. are properly encoded.

There's also the question of what happens if you do something like:

urlf.Sprintf("?%s", "data")

It could live in github.com/a-h/templ/urlf to avoid the name of oddity of templ.URLf or similar, but I don't mind templ.URL

I wonder if a builder style is better, since it turns issues with sprintf replacement into compile time issues:

urlbuilder.Build().Path("a").Path("b").Path(c).Query(key, value)

from templ.

joerdav avatar joerdav commented on July 23, 2024

There could be an unsafe counterpart too, urlf.UnsafeSprintf.

from templ.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.