Code Monkey home page Code Monkey logo

Comments (6)

headblockhead avatar headblockhead commented on August 25, 2024 2

So I believe that it could be worth the extra run time (around 1 minute) for a guaranteed fresh build?

What do you think?

from templ.

headblockhead avatar headblockhead commented on August 25, 2024

I had a closer look at the actions, and it does build using Nix, but a stale entry fetched from the magic-nix-cache is used if the hash is not changed for the vendors.

from templ.

headblockhead avatar headblockhead commented on August 25, 2024

Comparing cached and un-cached actions runs on my own fork of this repo:

  • First run, a normal commit: builds correctly and caches result.

  • Second run, a PR changes version numbers, without updating the hash: builds using stale versions of modules fetched from the cache, passes!?

  • The cache is deleted

  • Third run: mysterious hash mismatch appears from nowhere as the cache can no longer be used to fetch the outdated hash!

Logs and run times:

Run 1 (no cache, first run): passed in 2m 38s
image

Run 2 (commit is made, action uses cache from run 1): passed in 1m 20s
image

Run 3 (same commit, without cache): failed in 2m 28s
image

from templ.

chrisseto avatar chrisseto commented on August 25, 2024

Just hit this as well on darwin-arm64.

from templ.

a-h avatar a-h commented on August 25, 2024

Nice investigation and summary @headblockhead

I was thinking about swapping to gomod2nix so that go modules are more than just a blob of "stuff". Got an example here: https://github.com/a-h/nix-gomod2nix-example

I think that might allow caching to be used, but also means that Nix derived SBOMs are useful.

from templ.

a-h avatar a-h commented on August 25, 2024

I've updated the flake.nix to use gomod2nix instead. I think that should resolve the issue. If you were able to re-test it, that would be great.

from templ.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.