Code Monkey home page Code Monkey logo

Comments (9)

a-h avatar a-h commented on June 29, 2024 1

You could try using -open-browser=false to skip opening the browser automatically as a workaround.

Opening the browser is done using the https://github.com/cli/browser package, which should support the wslview command.

There's some information on the setup here: https://superuser.com/questions/1262977/open-browser-in-host-system-from-windows-subsystem-for-linux

Looking at the source code of cli/browser, it seems that it should attempt to use wslview, if it's available: https://github.com/cli/browser/blob/main/browser_linux.go

from templ.

Huzaifa-MS avatar Huzaifa-MS commented on June 29, 2024 1

Not sure will let you know my results if I get it working

from templ.

Huzaifa-MS avatar Huzaifa-MS commented on June 29, 2024 1

My bad I did not see this. The issue is beyond the scope of the repo and fixed via using wsl and ssh vscode into it or make poller for dev environment

from templ.

Huzaifa-MS avatar Huzaifa-MS commented on June 29, 2024

Thank you for taking the time to answer. I appreciate it

from templ.

a-h avatar a-h commented on June 29, 2024

I'm not really sure of any more action to take here @Huzaifa-MS - if everyone that's using Windows will have this problem, then I'd like to "fix" it, but I don't know anything about WSL, and can't test any resolution - I only have Mac and Linux computers.

Is the "fix" to install wslview in your Virtual Machine? Not sure.

from templ.

Huzaifa-MS avatar Huzaifa-MS commented on June 29, 2024

Yeah sorry I should've put it into discussion maybe. Not really a templ issue. More like a VM one

from templ.

a-h avatar a-h commented on June 29, 2024

It's no problem, just wondering if there should be a docs update, eg a note to let windows users that they need to install wslview or something.

Or perhaps it's a change required upstream in the browser package to check that a desktop env is available.

from templ.

Huzaifa-MS avatar Huzaifa-MS commented on June 29, 2024

This issue was not due to x11 forwarding. It was due to vscode editing on windows and cli running on wsl.
I believe templ solves this by using polling. So templ files are caught. but my .go files are not.
My application built on top of templ, similar to air does not poll.
Air I believe does implement polling.

go fsnotify polling issue: fsnotify/fsnotify#603

from templ.

a-h avatar a-h commented on June 29, 2024

Ah, that's interesting. I don't use Windows. When I'm coding with people that are using WSL, I usually advise them to run everything in WSL for consistency or it gets rather confusing.

Do you think we need to do anything here, or is this something to close?

from templ.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.