Comments (5)
I was wondering if there's an example of a naming convention for that in the standard library. The only similar thing I found so far is _unchecked
: https://doc.rust-lang.org/std/primitive.str.html?search=unchecked
But those methods are marked unsafe
because the result might be bad, so it's not really the same thing.
Another option might be send_ignore()
? Just playing around with names.
from cadence.
send_ignore
seems like a good choice to me.
from cadence.
I think every rust metrics lib I've seen returns a Result. I'm wondering if it's the wrong default in the first place w/ the nature of metrics, do most users ignore send results?
Maybe StatsdClient could have an error_handler (say defaulting to logging an error!) while changing send to not return a Result, w/ an alternative send API that does. Then at least the typical behavior isn't a complete ignore
from cadence.
Yeah that would also work for us. So you'd probably have send() -> ()
and try_send() -> Result
methods?
from cadence.
I like the idea of some sort of error handler such that errors aren't completely ignored. However, I'd rather not change the existing send method to Actually, I guess the breaking change might be fine since it's limited to the send() -> ()
and instead add a new method that makes use of the error handler.MetricBuilder
. Thoughts?
from cadence.
Related Issues (20)
- Remove uses of `static mut` in macros and macro tests HOT 2
- f64 support for distribution metric type HOT 3
- Make client methods generic on value type
- create migration guide
- Bump minimum Rust version due to Criterion deps
- Add f64 constructors to histograms and distributions
- Add tests for multiple types for each metric in cadence-macros
- Update all examples to have multiple types for each metric
- Datadog Event stream support HOT 1
- Create example of using conversion traits with custom type
- Add tags to all metrics HOT 5
- Instrumented allocator to verify heap allocations
- Remove client uses of Arc
- Remove MetricError description implementation
- Define parts of the API covered by semver
- Edition 2021 update
- Support being able to sample metrics HOT 3
- Add support for incrementing and decrementing a gauge HOT 2
- Distribution missing tags from StatsdClientBuilder HOT 3
- Support for metrics aggregation HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cadence.