Make StatsdClient more convenient to use about cadence HOT 5 CLOSED

Ha, funny you should mention this. I was just thinking about how to add some sort of MetricFormatter trait + impl to StatsdClient for #41 and it seemed a little ugly to have to start passing another generic param around.

Getting rid of the generic param and wrapping the sink in Arc (as well as making the client Clone) makes sense to me. Since this is a breaking change it would probably end up in 0.10.0 or later.

from cadence.

The only problem I see with wrapping the sink in an Arc<MetricSink + Sync + Send> is that the AsyncMetricSink, which uses a thread pool, is not Sync. Since it uses a std::sync::mpsc::Sender instance, it relies on being .cloned() between threads.

So, AsyncMetricSink is not compatible with using an Arc<MetricSink + Sync + Send> in the client struct. But, I've been wanting to get rid of AsyncMetricSink anyway.

So my plan is to deprecate AsyncMetricSink (per #34) and release version 0.10.0. After that I'll remove it and make this change in version 0.11.0.

from cadence.

Yay, excellent!

from cadence.

Hey @robinst,

I submitted a PR to remove the generic param from the client (#52) if you like to check it out. The biggest change was adding some docs to the client on the ways that it could be shared between threads, based on the use cases you've described here. Let me know what you think. Thanks!

from cadence.

Looks good! Just had a single comment. Like the docs as well, very nice.

from cadence.