Add optional support for Datadog extensions? about cadence HOT 7 CLOSED

to allow adding these myself by implementing Metric (if I read the sources correctly)

Computer says no:

error: module `types` is private
 --> src/handler.rs:9:5
  |
9 | use cadence::types::Metric;
  |     ^^^^^^^^^^^^^^^^^^^^^^

from cadence.

Hi @robinst

I'm only vaguely familiar with Datadog and their extensions to Statsd. Histograms look useful and they would probably be very straightforward to add support for. I can open a PR and cc you there if that works for you. Thanks!

from cadence.

Sounds good!

Histograms also in the spec you linked in the code, so maybe more implementations support it: https://github.com/b/statsd_spec/blob/master/README.md#histograms

Another useful thing is tags, which allow you to attach more information to a metric, see here: http://docs.datadoghq.com/guides/dogstatsd/#tags

The format is described later in the page under "Datagram Format".

from cadence.

Cool.

I'll open another issue for tag support since they'll be a bit more work and I'd like to think about how I'd implement them. Thanks again!

from cadence.

PR for histogram support #42. The docs related to the new trait are my interpretation of the Datadog docs as well as the Statsd spec. Let me know if I've gotten anything wrong.

from cadence.

Thanks @robinst! I'll probably end up cutting version 0.9.0 with this change in the next few weeks.

from cadence.

Cool, thanks! No rush by the way, I'll check out the release in the new year.

from cadence.