Comments (10)
Is not reproducible on 2.8.2, sending a build of my app to my beta testers using 2.8.2 now to see if it is fixed.
from pulley.
@glorysaber Thanks! I have been looking into these issues via #390
from pulley.
@glorysaber Can you replicate this issue on the Demo App for me? I am unable to replicate this feedback loop on my devices and the difference between 2.8.2 and 2.8.3 was very minor so I would love to track this loop down.
from pulley.
I just tried and was unable to reproduce in the default demo app. Ill take a look how we use it and see if there is a significant difference.
from pulley.
Ok so what makes it reproducible is this in the DrawerContentViewController.
override func traitCollectionDidChange(_ previousTraitCollection: UITraitCollection?) {
super.traitCollectionDidChange(previousTraitCollection)
guard let drawerVC = self.parent as? PulleyViewController else {
return
}
drawerVC.setNeedsSupportedDrawerPositionsUpdate()
}
This is what causes it to get in a loop with 2.8.3 but not 2.8.2
from pulley.
I will play around with that function I posted above to see if I can fix it.
from pulley.
@glorysaber I have pushed a theoretical fix to the xcode12
branch, if you could pull that down and see if that fixes your issue that would be much appreciated!
from pulley.
Yes thank you @ulmentflam! That seems to have done the trick!
from pulley.
@glorysaber Awesome, this update is going out now, thanks for your report!
from pulley.
This issue has been fixed in release 2.8.4
from pulley.
Related Issues (20)
- Unable to drag the drawer on iOS 14 HOT 5
- Animation HOT 4
- [QUESTION] Help with error: "When instantiating from Interface Builder you must provide container views with an embedded view controller. HOT 1
- App getting hang on iOS 14 using pulley HOT 1
- Navigator BAr
- Remove possibly unnecessary view
- [BUG] iPad panel mode problem HOT 1
- [BUG] The latest version Pulley 2.9.0 does not start PulleyViewController HOT 1
- [QUESTION] How to resize the content of the drawer as it is opened and closed HOT 1
- [BUG] There is a 20 pixel top inset for the PulleyPassThroughScrollView which doesn't accept user action HOT 3
- Is there any way to apply corner radius to only one side? HOT 2
- Open other controller within Drawer
- [QUESTION] Update bounceOverflowMargin HOT 1
- Pulley drawer dimming view appears after UINavigationViewController push new viewController
- [QUESTION] How to control bounce of pulley when it is used in UITabBarController
- Strange lines on mac catalyst 16
- Trying to instantiateViewController to open the pulley view controller
- I hope there are more convenient functions, such as the function of directly displaying the QR code
- Privacy manifest adoption HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pulley.