Comments (3)
There is a handle.close()
in the ID3Tag.parse callback, here.
Did you mean elsewhere?
from id3.
Ah, yes, but that version of the code is not what you get when you npm install id3js
. So the bug still exists in the npm-published version. I guess this bug should be "publish 1.1.3 to npm please." :)
BTW, is there some reason you've excluded your 'build' directory from the repo? I've forked to fix another issue and I've been just editing the big concatenated 'dist/id3.js' file directly, but I assume that's not how you do it. I meant to contact you about this before sending a pull request, but I hadn't gotten around to it.
from id3.
Sorry about that, its a bit of a mess.
Being that it began as a much smaller lib, I initially didn't have a solid build process. Then parts of it got forked off to other repos (dataview, reader.js) and now its a bit of a mess and a pain to update. Really, they should be deps now but we can't just npm
them as this works for browsers too.
You can edit dist/id3.js
but just remember some of the code is from dependencies, so if you feel the need to change those, there's likely a bug to be raised in their repos rather than this.
from id3.
Related Issues (20)
- ID3 2.0 Release HOT 5
- PRIV size not SynchSafeInt
- "Uncaught RangeError: Offset is outside the bounds of the DataView"
- Metadata from a file stored in GridFS
- Integration id3js and meteor
- DeprecationWarning: Calling an asynchronous function without callback is deprecated
- "DeprecationWarning: Calling an asynchronous function without callback is deprecated" HOT 1
- 'null' tags returned for correctly tagged file... ? HOT 4
- image tag does not contain the image that other software uses to display album art
- Get the encoding of the ID3
- Support promises instead of callbacks HOT 3
- Error with Node 11.5 [10.0.0+]"Callback must be a function" HOT 3
- ID3v1 tags no longer trim null bytes HOT 1
- TypeScript types need to be exposed for entrypoint HOT 1
- Nodered in Docker run issue
- Uncaught URIError: URI malformed with special characters HOT 1
- Years are returned as null HOT 2
- Documentation need for using the module in. and html page
- Add Blob Type
- Usage in a web browser with a bundler
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from id3.