Facing a strange crash time to time about networking HOT 3 CLOSED

Fix published in 5.0.3, thanks!

https://github.com/3lvis/Networking/releases/tag/5.0.3

Finding this project helpful? Consider supporting further development and support by becoming a sponsor:

👉 https://github.com/sponsors/3lvis

from networking.

Hello @mkll!

1.- I think your logic makes sense, somehow the URL session configuration should have been connected to the way caching is handled in Networking. Sadly, it wasn't done that way, instead caching is handled at the call level. Whenever you make a Networking call you can decide the caching level, the default is none.

If I were to make the change now of connecting URL session configuration with how caching is handled I'm worried it might lead to inconsistent behavior, where some people using ephemeral tried to do caching here and there and it wouldn't work.

If caching is none by default and you aren't using any caching I'm surprised why this crash is even happening. Either way, it's something we need to fix.

2.- The fatalError is not necessary. I'll remove it. If we can't construct the URL in this method we should just escape instead of crashing.

3.- My answer here is similar to the 1st one, even though your logic makes sense I'm afraid it could cause unwanted behavior.

from networking.

@3lvis thanks for the clarification.
Imagine how surprised I was when I saw this crash for the first time. Whaaat? Caaache? But how? :)
As for me, removing fatalError seems to be enough to eliminate negative impact. It's just an overkill here.

from networking.