Code Monkey home page Code Monkey logo

Comments (12)

arda971 avatar arda971 commented on June 17, 2024 1

ok i will add icon

from memory-match-react.

arda971 avatar arda971 commented on June 17, 2024

how do you push to origin master after changed

from memory-match-react.

3daddict avatar 3daddict commented on June 17, 2024

Try to create a new branch and then do a pull request comparing the new branch the dev branch.

from memory-match-react.

arda971 avatar arda971 commented on June 17, 2024

i did a icon branch did not work i am not allowed to push

from memory-match-react.

arda971 avatar arda971 commented on June 17, 2024

i try with dev

from memory-match-react.

3daddict avatar 3daddict commented on June 17, 2024

Great job submitting the pull request. I'm getting an error after npm installing react-fontawesome
Could not find icon {prefix: "fas", iconName: "spa"}
Do you know what is causing this?

from memory-match-react.

arda971 avatar arda971 commented on June 17, 2024

you need to import the Fontawesome libraries in the app.js and then you can import the icon that you need
look at my second pull request in all in there

from memory-match-react.

arda971 avatar arda971 commented on June 17, 2024

npm i --save @fortawesome/fontawesome-svg-core npm i --save @fortawesome/free-solid-svg-icons npm i --save @fortawesome/react-fontawesome

from memory-match-react.

3daddict avatar 3daddict commented on June 17, 2024

Yep that second pull request fixed the issue. Would you like to make the 12 cards with 6 icons to match?
Here is an example: https://scotch.io/tutorials/how-to-build-a-memory-matching-game-in-javascript
I have the flip function already programmed where the color sides will be the icon.
You can keep the current icons you made as the back of the cards,
Let me know if you have questions.

from memory-match-react.

arda971 avatar arda971 commented on June 17, 2024

the cards are they random and unique ? should i use the three color so 4 per color?

from memory-match-react.

3daddict avatar 3daddict commented on June 17, 2024

To start card location can be static. Later we can make a feature to populate the dom randomly on each game start. Colors can be removed, they were there to show front and back of the card.

from memory-match-react.

3daddict avatar 3daddict commented on June 17, 2024

@arda971 very nice work!!!

from memory-match-react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.