Code Monkey home page Code Monkey logo

Comments (11)

tonydspaniard avatar tonydspaniard commented on July 23, 2024

did you run composer update? what is the version you use?

from yii2-date-picker-widget.

SDKiller avatar SDKiller commented on July 23, 2024
        "name": "2amigos/yii2-date-picker-widget",
        "version": "dev-master",
        "version_normalized": "9999999-dev",
        "source": {
            "type": "git",
            "url": "https://github.com/2amigos/yii2-date-picker-widget.git",
            "reference": "c61989074044185f35cb47379e8715b9729c5674"
        },

from yii2-date-picker-widget.

tonydspaniard avatar tonydspaniard commented on July 23, 2024

I have found the issue. Will fix it tonight asap: https://github.com/2amigos/yii2-date-picker-widget/blob/master/src/DateRangePicker.php#L74 and https://github.com/2amigos/yii2-date-picker-widget/blob/master/src/DateRangePicker.php#L84

Mind removing the ones on the L84 and check if that fixes the issue?

from yii2-date-picker-widget.

SDKiller avatar SDKiller commented on July 23, 2024

Also had to remove from https://github.com/2amigos/yii2-date-picker-widget/blob/master/src/DateRangePicker.php#L91 and https://github.com/2amigos/yii2-date-picker-widget/blob/master/src/DateRangePicker.php#L99

from yii2-date-picker-widget.

SDKiller avatar SDKiller commented on July 23, 2024

I suppose input-group should be in lines 91 and 99 instead, this fixed everything:

        if ($this->form) {
            Html::addCssClass($this->options, 'datepicker-from');
            Html::addCssClass($this->optionsTo, 'datepicker-to');
            $inputFrom = $this->form->field(
                $this->model,
                $this->attribute,
                [
                    'template' => '{input}{error}',
                    'options' => ['class' => 'input-group datepicker-range'],
                ]
            )->textInput($this->options);
            $inputTo = $this->form->field(
                $this->model,
                $this->attributeTo,
                [
                    'template' => '{input}{error}',
                    'options' => ['class' => 'input-group datepicker-range'],
                ]
            )->textInput($this->optionsTo);
        } else {

qip shot - screen 614 31 03 15

from yii2-date-picker-widget.

SDKiller avatar SDKiller commented on July 23, 2024

Ah, sorry, forgot about .form-control:first-child. My fix results rounded corners for $inputTo

from yii2-date-picker-widget.

tonydspaniard avatar tonydspaniard commented on July 23, 2024

@SDKiller mind showing the fix?

from yii2-date-picker-widget.

tonydspaniard avatar tonydspaniard commented on July 23, 2024

i have pushed some changes... mind checking if that fixed it?
I want to know prior updating tags.

from yii2-date-picker-widget.

SDKiller avatar SDKiller commented on July 23, 2024

As I said earlier - it fixes position, but adding input-group affects corners of $inputTo:

qip shot - screen 615 01 04 15

Had to adjust css also (nesessary only if form is specified in widget config):

.input-group > .datepicker-to.form-control:first-child {
    border-radius: 0 4px 4px 0;
}

Without form widget plays well without css adjustments.

from yii2-date-picker-widget.

tonydspaniard avatar tonydspaniard commented on July 23, 2024

The problem was on the assets not on the style. I have fixed, will update the version tag soon.

from yii2-date-picker-widget.

tonydspaniard avatar tonydspaniard commented on July 23, 2024

done... Fixed on 1.0.5 Thanks for the help!

from yii2-date-picker-widget.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.