Multiple assignments to same variable in MQTTClient.h about arduino-mqtt HOT 4 CLOSED

Thanks for raising this. However, this file is part of the underlying Eclipse Paho library. Therefore, we should raise the issue on their repository: https://github.com/eclipse/paho.mqtt.embedded-c. Unfortunately, their repository doesen't get much attention lately. We can try ;).

from arduino-mqtt.

Got it. I'll double check the code is funky there and make a note in that repo so even if it's not updated, there'll be a record should it barf on some new platform.

from arduino-mqtt.

Just checked their master/head repo and it's actually fixed there. The preincrement is replaced with a simple "next=next+1". But, of course, the master/1.0.0 tag doesn't have it. :( So should they ever do a release it'll be OK.

https://github.com/eclipse/paho.mqtt.embedded-c/blob/master/MQTTClient/src/MQTTClient.h
...snip...
int getNext()
{
return next = (next == MAX_PACKET_ID) ? 1 : next + 1;
}

from arduino-mqtt.

Thanks for the update!

from arduino-mqtt.