Bot hits the 150s timeout while running in foreground about hippybot HOT 19 CLOSED

Now that's odd, in init I set the PING_FREQUENCY attribute to 60 which jabberbot should use to ping Hipchat's xmpp server every 60 seconds, so either there's a bug in jabberbot's pinging, or perhaps Hipchat's ponging.

Cheers, I'll look into it.

from hippybot.

if it's any help, these are my versions:
Ubuntu 11.04 x64
python 2.7.1 (system default)
python-xmpp 0.4.1-cvs20080505.2 (installed via apt-get)
jabberbot 0.14 (installed via pip)
hippybot f39eeed

from hippybot.

@treystout I have exactly the same OS/versions and I'm unable to reproduce, could you retest with the latest HEAD (b15aea0 at time of posting)

from hippybot.

I still can't replicate this on HEAD so I'm going to close for now, please feel free to re-open if still an issue.

from hippybot.

This is happening for me in OSX (10.7.2) as well.

hippybot==1.2.0
xmpppy==0.5.0rc1
jabberbot==0.14

from hippybot.

I periodically encounter this issue myself, I'm going to bring this up with HipChat as the Jabber backend doesn't seem to be responding to an XMPP ping.

from hippybot.

Awesome.. hope they can fix it.

Thanks!

from hippybot.

Hi - Garret from HipChat here. Any data sent over the connection counts as a keepalive to us so as long as we've received something in the last 150s your connection won't get dropped. I'm assuming jabberbot's ping logic is to blame (or isn't actually being run properly).

FWIW - our clients send a single space character as a keepalive to cut down on bandwidth although we also support client-to-server XMPP ping (XEP-019) for times when a pong is helpful.

from hippybot.

@powdahound cheers Garret, I'll look into placing my own single-space message in the event loop.

from hippybot.

@mwarkentin could you give 5bd399f a go?

I've had my own instance connected overnight, over long periods of inactivity (both by it and other users) without issue.

from hippybot.

How do I install a specific commit? I installed with pip.

Sent from my iPhone

On 2011-10-26, at 6:52 AM, Wesley [email protected] wrote:

@mwarkentin could you give 5bd399f a go?

I've had my own instance connected overnight, over long periods of inactivity (both by it and other users) without issue.

Reply to this email directly or view it on GitHub:
#2 (comment)

from hippybot.

pip install https://github.com/1stvamp/hippybot/tarball/master#egg=hippybot should install it via github

from hippybot.

Not heard anything else on this and not ran into the issue myself, so closing.

from hippybot.

I updated to master but the problem still persisted. And, by the way, the update is broken due to symlink to src/daemon.py not created.

from hippybot.

Apparently the problem is with JabberBot's handling of its private __lastping variable. It resets this variable when it receives a packet from the server. I suppose this might be reasonable with other jabberd but, as explained by @powdahound, Hipchat only counts the packets that are sent from client, not packets that Hipchat itself has sent. So there might be times when the if statement will fail because time.time() - self.__JabberBot_lastping is less than PING_FREQUENCY.

I suggest another variable be used to track last send_message call. Or JabberBot be modified to track packet sending instead of receiving.

from hippybot.

I can confirm what namlol has to say, I inserted some prints around the _idle_ping function and you can see the _JabberBot__lastping counter resetting periodically. I suppose whether you experience this bug probably depends on how busy your hipchat server is.

from hippybot.

Jabberbot itself has fixed this issue. See: http://sourceforge.net/p/pythonjabberbot/code/ci/31f6df3a5ec41af93d9c2e432c19f64973257d1e/

from hippybot.

Excellent news about it being fixed upstream in jabberbot, sorry I
haven't been much use with this issue - lots of life getting in the
way.

I'll close this issue when jabberbot have released to pypi so I can
bump the minimum version in requirements.txt

On 10 Feb 2012, at 08:56 PM, namlol
[email protected]
wrote:

Jabberbot itself has fixed this issue. See: http://sourceforge.net/p/pythonjabberbot/code/ci/31f6df3a5ec41af93d9c2e432c19f64973257d1e/

---

Reply to this email directly or view it on GitHub:
#2 (comment)

from hippybot.

Fixed in upstream and I've bumped the minimum requirement of jabberbot to 0.15 and published new hippybot release => 1.2.3

from hippybot.