[Bug] URL is not wrapped within double quotes in the exported CSV about 1history HOT 4 CLOSED

Sounds good to me

from 1history.

Notes on exporting RFC4180 compliant CSV files:

• If the value contains line breaks or double quotes, these values should also be enclosed in double quotes.

  Both characters are percent-encoded in most URLs. However, since percent encoding is not required, double quotes may also be included in URLs.

  Also, double quotes may be included in the page title. If URLs are enclosed in double quotes in the exported CSV file, then I would think that page titles containing double quotes should also be enclosed in double quotes.

• If the value contains double quotes, each double quote should be escaped.

  Each double quote should be increased to two (" -> ""). For example, the following values are:

  title
  foo
  foo"bar
  bar,baz
  baz""qux
  "quux"
  foo"bar,baz""qux"

  will be written to the CSV as a string like this:

  title
  foo
  "foo""bar"
  "bar,baz"
  "baz""""qux"
  """quux"""
  "foo""bar,baz""""qux"""
  

However, RFC4180 is not a CSV specification. CSV has a history in which different implementations existed for each application without a specification. RFC4180 was defined in response to this, there are still many applications that do not conform to RFC4180. Therefore, there is no need to strictly conform to RFC4180.

Although, I think it is better to comply with RFC4180 as much as possible to include page titles with confusing values such as "foo bar" in the CSV.

from 1history.

https://docs.rs/csv/latest/csv/ may help implementing this.

from 1history.

I noticed this bug was fixed when I updated onehistory installed by Cargo. Thank you very much!

from 1history.