Comments (3)
cmmarslender
commented on August 15, 2024
I'm particularly a fan of the more specific /vendor/ and /release/ so we don't accidentally ignore a folder called vendor inside of say, a "sass" folder 👍
from generator-wp-make.
cmmarslender
commented on August 15, 2024
Before we merge this, we should remove the ignore on the composer.lock file - want to make sure we are able to deploy known composer dependencies, and need that file to do so.
from generator-wp-make.
lkwdwrd
commented on August 15, 2024
Agree with this idea -- The general team is pushing to get the V1 rewrite done, which will include these. We're trying not to make many changes to the legacy version at this point, but the plan is to look closely at the files output after build, including the .gitignore, which yes, should really not have the composer.lock file in it amongst the other things mentioned here.
I'll leave this issue open for anyone wanting to write up the PR, or as a reminder as we finish out version 1. if we push version 1 before a PR comes through I'll close as wontfix.
from generator-wp-make.
Related Issues (20)
- Any reason not to exclude the /tasks dir when running the build command (copy)? HOT 1
- Missing `_bowerrc` starter file HOT 1
- README instructions HOT 6
- Restrict multiple variable declarations `disallowMultipleVarDecl` in jscs by default
- Error if the user has not entered a Project Root PHP Namespace in the set-up prompt
- New eslint recommendation HOT 1
- Manual Install of Extendable Yeoman Required
- yo not finding wp-make HOT 1
- Errors when running the version installed via npm HOT 2
- Error when running grunt watch HOT 5
- Running a new install, Grunt is broken. HOT 1
- Update .editorconfig to match best practices HOT 2
- Change default domain from .dev to .local HOT 4
- Having problems using it
- Git clone vs npm install, and version discrepancies HOT 4
- Namespace not imported HOT 1
- Bringing component library into the make generator HOT 4
- Generated Grunt HOT 1
- Yeoman can't see generator after installing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from generator-wp-make.