Code Monkey home page Code Monkey logo

Comments (7)

helen avatar helen commented on July 17, 2024 2

Hi @kevindaus! I totally agree, we should add sample workflow files to https://github.com/10up/plugin-scaffold, which you can use as a template when starting a new repo right in GitHub. Is that something you’d be interested in submitting a pull request for? I’m also happy to take care of it.

from action-wordpress-plugin-deploy.

helgatheviking avatar helgatheviking commented on July 17, 2024 1

@helen Hi Helen! thank you so much for replying. The first example I looked at for this was in ElasticPress which had a GITHUB_TOKEN in it. But looking at the docs again, and now you've confirmed, that isn't necessary. Thanks for clearing that up!

from action-wordpress-plugin-deploy.

madiodio avatar madiodio commented on July 17, 2024

Hi there, is there at least any guide on how to get this running at all ? As #10 suggested. It would be awesome if there was a basic step by step to make sure you're not going to run on some errors that could be avoided.

I've migrated this to the new syntax (from HCL to .yml) and can't run successfully the action anymore. It constantly fails on this message that's not really helping fatal: not a git repository (or any parent up to mount point /github)

Thanks.

from action-wordpress-plugin-deploy.

helen avatar helen commented on July 17, 2024

@madiodio You’ve commented out the - uses: actions/checkout@master step, which is necessary to have any of the GitHub repo available for use during the run. While I’m sympathetic to confusion as people get used to the new syntax and Actions in general, I’m not sure it’s worth duplicating general Actions documentation here. What do you think would make the basic example clearer?

from action-wordpress-plugin-deploy.

madiodio avatar madiodio commented on July 17, 2024

@helen Thanks for pointing that out, including -uses: actions/checkout@master in the steps actually fixes the issue. What confused me was whether or not the npm install was needed at all.

I totally get that it could make duplicate the actual Actions documentations but a simple step by step would not hurt IMHO. I believe this would help maintain this repo like helping reduce issues like this and resolve bugs based on what step the user did get stuck on. For example:

Installation

Step 1 :

  • Register your secrets env. keys (SVN_USERNAME and SVN_PASSWORD) ...
  • Optionally add SLUG, VERSION, ASSETS_DIR ...

Step 2 : Create a file in .github/workflow named main.ymlfor example, copy the example, make changes if necessary (SLUG) and paste it inside the main.yml file that you just created

Step 3 (Optional) : Create a .distignore (or .gitattributes adding export-ignore at the end of each line) to make sure you're excluding files/folders you don't want to end in the deployed plugin folder

Step 4 : Deploy your plugin as you would by tagging a new version and pushing.

Also, you can fork this repo (link to a template repo maybe 10up/plugin-scaffold ?) clone it and deploy using the previous steps.


If this sounds ok for you I can put together a PR.

Thanks.

from action-wordpress-plugin-deploy.

helgatheviking avatar helgatheviking commented on July 17, 2024

@madiodio I would love a step by step. I'm meandering my way through right now. I'm stuck on what permissions you need to give your github token so a screenshot of that would be a nice addition to the docs too.

from action-wordpress-plugin-deploy.

helen avatar helen commented on July 17, 2024

@helgatheviking For the typical use case there shouldn’t be much more to it besides copying the base workflow file and adding the SVN_USERNAME and SVN_PASSWORD secrets to the repo settings. GITHUB_TOKEN is not required for this particular Action and is automatically provided by the Actions environment so there’s nothing to configure. Can you describe what you’re doing?

from action-wordpress-plugin-deploy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.